Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove github.com/dgrijalva/jwt-go #3459

Closed
wants to merge 1 commit into from
Closed

Remove github.com/dgrijalva/jwt-go #3459

wants to merge 1 commit into from

Conversation

brackendawson
Copy link
Contributor

github.com/dgrijalva/jwt-go is unmaintained and vulnerable to
CVE-2020-26160. Updating github.com/Azure/go-autorest removes
the dependency.

Signed-off-by: Bracken Dawson abdawson@gmail.com

fixes #3361

@brackendawson
Copy link
Contributor Author

How are we planning to release v2.7.2? I see other milestone issues have been merged into main but if we want v2.7.2 to still not be a module then we'll have to backport those changes into a different branch. This change will look very different without modules.

@brackendawson
Remove github.com/dgrijalva/jwt-go
c83539d 
github.com/dgrijalva/jwt-go us unmaintained and vulnerable to
CVE-2020-26160. Updating github.com/Azure/go-autorest removes
the dependency.

Signed-off-by: Bracken Dawson <abdawson@gmail.com>
@brackendawson
Copy link
Contributor Author

The direct dependency that ultimately brings in github.com/dgrijalva/jwt-go is github.com/Azure/azure-sdk-for-go but that hasn't been updated yet, so updating the indirect dependency github.com/Azure/go-autorest is needed.

@wy65701436
Copy link
Collaborator

thanks @brackendawson , this PR should be backported to v2.7.2.

wy65701436
wy65701436 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Collaborator

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

milosgajdos
milosgajdos approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@milosgajdos milosgajdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This made me think of #3138 which updates autorest and crypto indirect deps, etc.

We should probably close that one if we merge this one in CC: @brackendawson @wy65701436

brackendawson added a commit to brackendawson/distribution that referenced this pull request Jul 29, 2021
@brackendawson
Remove github.com/dgrijalva/jwt-go
54451ee 
By updating github.com/Azure/go-autorest/autorest to v.0.11.19 (10e0b31633f168ce1a329dcbdd0ab9842e533fb5)

Backport of github.com/distribution#3459
@brackendawson brackendawson mentioned this pull request Jul 29, 2021
Closed
brackendawson added a commit to brackendawson/distribution that referenced this pull request Jul 29, 2021
@brackendawson
Remove github.com/dgrijalva/jwt-go
5906192 
By updating github.com/Azure/go-autorest/autorest to v.0.11.19 (10e0b31633f168ce1a329dcbdd0ab9842e533fb5)

Backport of github.com/distribution#3459

Signed-off-by: Bracken Dawson <abdawson@gmail.com>
thaJeztah
thaJeztah reviewed Jul 29, 2021
View reviewed changes
go.sum
@@ -43,6 +53,8 @@ github.com/docker/libtrust v0.0.0-20150114040149-fa567046d9b1 h1:ZClxb8laGDf5arX
github.com/docker/libtrust v0.0.0-20150114040149-fa567046d9b1/go.mod h1:cyGadeNEkKy96OOhEzfZl+yxihPEzKnqJwvfuSUqbZE=
github.com/felixge/httpsnoop v1.0.1 h1:lvB5Jl89CsZtGIWuTcDM1E/vkVs49/Ml7JJe07l8SPQ=
github.com/felixge/httpsnoop v1.0.1/go.mod h1:m8KPJKqk1gH5J9DgRY2ASl2lWCfGKXixSwevea8zH2U=
github.com/form3tech-oss/jwt-go v3.2.2+incompatible h1:TcekIExNqud5crz4xD2pavyTgWiPvpYe4Xau31I0PRk=
github.com/form3tech-oss/jwt-go v3.2.2+incompatible/go.mod h1:pbq4aXjuKjdthFRnoDwaVPLA+WlJuPGy+QneDUgJi2k=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this on the version for 2.7; https://github.com/distribution/distribution/pull/3465/files#r679126223

This looks to be pulling in v3.2.2, which is missing a security fix in v3.2.4; form3tech-oss/jwt-go@v3.2.2...v3.2.4 (see https://github.com/form3tech-oss/jwt-go/tree/v3.2.4)

To get a more current version, you can add a //indirect to the go.mod

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was just checking the same thing. I think in this branch as long as github.com/Azure/go-autorest/autorest still uses github.com/form3tech-oss/jwt-go then using an //indirect to bump it to 3.2.4 is good.

go.mod
@@ -14,7 +14,6 @@ require (
github.com/bugsnag/osext v0.0.0-20130617224835-0dd3f918b21b // indirect
github.com/bugsnag/panicwrap v0.0.0-20151223152923-e2c28503fcd0 // indirect
github.com/denverdino/aliyungo v0.0.0-20190125010748-a747050bb1ba
github.com/dgrijalva/jwt-go v0.0.0-20170104182250-a601269ab70c // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a // indirect for the jwt-go module, to force it to the most current (v3.2.4) version (see my other comment)

github.com/form3tech-oss/jwt-go v3.2.4+incompatible // indirect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly it's not that easy, v3.2.4 introduced an empty mod file which means the import line has to change to github.com/form3tech-oss/jwt-go/v3 now, which is a code change in github.com/Azure/go-autorest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think there is no valid way to import 3.2.4 with that mod file in there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps someone should open a PR to remove it; looks like it may have been unintentional that it was added.

Either that and/or forward-port the security fix to the upstream (form3tech-oss/jwt-go#14)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the main branch, because form3tech-oss/jwt-go@v3.2.4 contains an invalid go.mod file (the module string should be versioned). Our only options are:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a workaround, it's possible to use a commit as version; in that case I think go mod should work (run go mod tidy afterwards to generate the pseudo version)

github.com/form3tech-oss/jwt-go a211650c6ae1cff6d7347d3e24070d65dcfb1122 // indirect

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also opened form3tech-oss/jwt-go#17 to remove the go.mod 😅

@thaJeztah thaJeztah mentioned this pull request Jul 29, 2021
Merged
@brackendawson brackendawson mentioned this pull request Jul 29, 2021
Merged
@thaJeztah
Copy link
Member

Haven't come round to it yet, but I was planning to open a PR in github.com/Azure/go-autorest to replace it with https://github.com/golang-jwt/jwt

Because the https://github.com/form3tech-oss/jwt-go has now been archived (see form3tech-oss/jwt-go#17 (comment))

@thaJeztah thaJeztah mentioned this pull request Aug 13, 2021
Merged
2 tasks
@thaJeztah
Copy link
Member

I opened Azure/go-autorest#645 to switch Azure/go-autorest to use the new module. Unfortunately couldn't update it to v4, because the main package there uses go dep, which doesn't support the versioned import paths.

@thaJeztah
Copy link
Member

Heads up; Azure/go-autorest#645 was merged, and now switches Azure/go-autorest to github.com/golang-jwt/jwt/v4. I don't think a release was tagged yet, but may be soon.

@thaJeztah thaJeztah mentioned this pull request Aug 25, 2021
Merged
@milosgajdos
Copy link
Member

We should close this PR as #3138 addressed this.

@thaJeztah
Copy link
Member

Yes, looks like this was resolved in #3138

Thanks @brackendawson !

@thaJeztah thaJeztah closed this Aug 26, 2021
@thaJeztah thaJeztah mentioned this pull request Nov 23, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah left review comments

@milosgajdos milosgajdos milosgajdos approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@milosgajdos milosgajdos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jwt-go needs to uplift to 4.0.0-prview1 or later to fix some security issue
5 participants
@brackendawson @wy65701436 @thaJeztah @milosgajdos @deleteriousEffect