GitHub CI: Reinstate Toooba test for macos-13 #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A workaround for elf_to_hex on Ubuntu is no longer needed
quark17
force-pushed
the
reinstate-toooba-ci
branch
from
7ab6e67
to
5f9ff7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues with
elf_to_hexhave been fixed in the Toooba repo.The problem was that
elf_to_hex.chad a large static array (size 0x90000000), which has been observed to cause compilation problems on other systems (relocation errors). On macOS 13, it resulted in the C compiler producing an executable with a dynamic lib which failed to load. It was fixed by dynamically creating the array withmalloc.