Update test for Bluespec Inc bug 1490 #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The heap overflow in GHC 9.8 (actually starting with 9.6) is correct. Earlier GHC 9.4 can be seen to use the same amount of memory, but is not correctly handling the RTS -M flag. If possible, the exp file should be updated to more directly test what the concern is -- whether that's a trace of the BSC elaboration or GHC's reporting of the live bytes (which is smaller than the actual heap usage, due to fragmentation) or something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heap overflow in GHC 9.8 (actually starting with 9.6) is correct. Earlier GHC 9.4 can be seen to use the same amount of memory, but is not correctly handling the RTS -M flag. So I have removed the GHC version check and slightly increased the maximum heap for the two tests which actually use more heap (but not as much as the one test which is expected fail, which needs more than 400M).