Package updates / chores for suppressing a warning and fixing for a typo #744
Conversation
update the packages' version to match with as Flutter was bumped up to v3
chunghha
changed the title
|
@renefloor please review. |
| @@ -1,6 +1,7 @@ | |||
| import 'package:cached_network_image/cached_network_image.dart'; | |||
| import 'package:flutter/material.dart'; | |||
| import 'package:baseflow_plugin_template/baseflow_plugin_template.dart'; | |||
| // ignore: depend_on_referenced_packages | |||
There was a problem hiding this comment.
This shouldn't be ignored, the example should depend on it
There was a problem hiding this comment.
To fix this warning without this comment, we then need to specify flutter_blurhash to the pubspec. I wasn't sure that's what you'd like because the package is transitive dependency. But, I can make an update per what's you'd like to have, just let me know.
| flutter_lints: ^1.0.4 | ||
| flutter_lints: ^2.0.1 |
There was a problem hiding this comment.
This is not really missed, I was planning to do this later.
There was a problem hiding this comment.
Okay. So leave it as this change? Basically no impact by this update though because new rules in updated packages are not used anyway. In a separate commit, I'd like to suggest using all_lint_rules_community to include new rules automatically.
| ///If there is no placeholer OctoImage does not fade, so always set an | ||
| ///If there is no placeholder OctoImage does not fade, so always set an |
| cached_network_image_platform_interface: ^1.0.0 | ||
| cached_network_image_web: ^1.0.0 | ||
|
|
||
|
|
||
| dev_dependencies: | ||
| flutter_test: | ||
| sdk: flutter | ||
| mocktail: ^0.1.1 | ||
| flutter_lints: ^1.0.4 | ||
| mocktail: ^0.3.0 |
There was a problem hiding this comment.
Does this upgrade bring any benefits?
There was a problem hiding this comment.
No, because tests don't use any breaking changes in updated mocktail. This update just verifies that.
Codecov Report
@@ Coverage Diff @@
## develop #744 +/- ##
========================================
Coverage 95.67% 95.67%
========================================
Files 4 4
Lines 162 162
========================================
Hits 155 155
Misses 7 7
Continue to review full report at Codecov.
|
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Just chores which seem missed with the 3.2.1 release
no behavior change by the commits in this PR
🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
📝 Links to relevant issues/docs
v3.2.1 bumped Flutter version to v3. However, packages like flutter_lints were not updated. So this PR addresses that. Also, chores for suppressing a lint warning and fixing a typo are included.
🤔 Checklist before submitting
N/A for not checked on