Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package updates / chores for suppressing a warning and fixing for a typo #744

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Package updates / chores for suppressing a warning and fixing for a typo #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
690de7c
build(lib): lib package update
chunghha May 17, 2022
5f9b353
chore: ignore the lint warning
chunghha May 17, 2022
1d2764e
chore: fix the typo
chunghha May 17, 2022
875b974
build(lib): set the version per review
chunghha May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions cached_network_image/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'package:cached_network_image/cached_network_image.dart';
import 'package:flutter/material.dart';
import 'package:baseflow_plugin_template/baseflow_plugin_template.dart';
// ignore: depend_on_referenced_packages
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be ignored, the example should depend on it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix this warning without this comment, we then need to specify flutter_blurhash to the pubspec. I wasn't sure that's what you'd like because the package is transitive dependency. But, I can make an update per what's you'd like to have, just let me know.

import 'package:flutter_blurhash/flutter_blurhash.dart';

void main() {
Expand Down
2 changes: 1 addition & 1 deletion cached_network_image/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
flutter_lints: ^1.0.4
flutter_lints: ^2.0.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really missed, I was planning to do this later.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. So leave it as this change? Basically no impact by this update though because new rules in updated packages are not used anyway. In a separate commit, I'd like to suggest using all_lint_rules_community to include new rules automatically.



# For information on the generic Dart part of this file, see the
Expand Down
2 changes: 1 addition & 1 deletion cached_network_image/lib/src/cached_image_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ class CachedNetworkImage extends StatelessWidget {
var octoProgressIndicatorBuilder =
progressIndicatorBuilder != null ? _octoProgressIndicatorBuilder : null;

///If there is no placeholer OctoImage does not fade, so always set an
///If there is no placeholder OctoImage does not fade, so always set an
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one

///(empty) placeholder as this always used to be the behaviour of
///CachedNetworkImage.
if (octoPlaceholderBuilder == null &&
Expand Down
6 changes: 3 additions & 3 deletions cached_network_image/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,16 @@ dependencies:
flutter:
sdk: flutter
flutter_cache_manager: ^3.3.0
octo_image: ^1.0.0
octo_image: ^1.0.1
cached_network_image_platform_interface: ^1.0.0
cached_network_image_web: ^1.0.0


dev_dependencies:
flutter_test:
sdk: flutter
mocktail: ^0.1.1
flutter_lints: ^1.0.4
mocktail: ^0.3.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this upgrade bring any benefits?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because tests don't use any breaking changes in updated mocktail. This update just verifies that.

flutter_lints: ^2.0.1
file: ^6.1.0

environment:
Expand Down