Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electron Fiddle #1128

Merged
merged 36 commits into from May 18, 2022
Merged

Add Electron Fiddle #1128

merged 36 commits into from May 18, 2022

Conversation

Crilum
Copy link
Contributor

@Crilum Crilum commented Nov 9, 2021

Electron Fiddle lets you create and play with small Electron experiments. It greets you with a quick-start template after opening – change a few things, choose the version of Electron you want to run it with, and play around. Then, save your Fiddle either as a GitHub Gist or to a local folder. Once pushed to GitHub, anyone can quickly try your Fiddle out by just entering it in the address bar.

Remove deskreen from this pr.. 🤦‍♂️
Add Electron Fiddle
Update install-32 to latest version
@Itai-Nelken
Copy link
Contributor

@Crilum can you try to remove the extra commits in your next pr?

@cycool29
Copy link
Contributor

cycool29 commented Nov 9, 2021

Ya, learn to use git. This should be easily done with git reset.
I think there is also a function to revert changes in Github Desktop, not very sure about it.

@Crilum
Copy link
Contributor Author

Crilum commented Nov 9, 2021

@Itai-Nelken @cycool29 Yeah.. Sorry. Thanks for telling me about git reset.

@Crilum

This comment was marked as off-topic.

@Crilum

This comment was marked as off-topic.

@Itai-Nelken
Copy link
Contributor

@Crilum wait until all your pr's are merged/closed and then delete your fork and reclone. we can squash and merge the pr's so they appear as a single commit.

@Crilum
Copy link
Contributor Author

Crilum commented Nov 11, 2021

Yeah, that's the other thing I was thinking too. Does this PR look good?

@Crilum
Copy link
Contributor Author

Crilum commented Nov 15, 2021

So, I think this is affected by the same problem as Deskreen. But running it with --no-sandbox gives me this:

$ electron-fiddle --no-sandbox
Creating main window
Usage: main [options] [command]

Options:
  -h, --help                                   display help for command

Commands:
  bisect [options] <goodVersion> <badVersion>  Find where regressions were introduced
  test [options]                               Test a fiddle
  help [command]                               display help for command


Example calls:
  $ electron-fiddle bisect 10.0.0 11.2.0 --fiddle /path/to/fiddle
  $ electron-fiddle bisect 10.0.0 11.2.0 --fiddle /path/to/fiddle --full
  $ electron-fiddle test --version 11.2.0 --fiddle /path/to/fiddle
  $ electron-fiddle test --version 11.2.0 --fiddle 8c5fc0c6a5153d49b5a4a56d3ed9da8f
  $ electron-fiddle test --version 11.2.0 --fiddle https://gist.github.com/ckerr/8c5fc0c6a5153d49b5a4a56d3ed9da8f/

CommanderError: (outputHelp)
    at Command._exit (/usr/lib/electron-fiddle/resources/app.asar/node_modules/commander/index.js:888:26)
    at Command.help (/usr/lib/electron-fiddle/resources/app.asar/node_modules/commander/index.js:2050:10)
    at Command._parseCommand (/usr/lib/electron-fiddle/resources/app.asar/node_modules/commander/index.js:1521:14)
    at Command.parse (/usr/lib/electron-fiddle/resources/app.asar/node_modules/commander/index.js:1292:10)
    at Command.parseAsync (/usr/lib/electron-fiddle/resources/app.asar/node_modules/commander/index.js:1318:10)
    at Object.m [as processCommandLine] (/usr/lib/electron-fiddle/resources/app.asar/dist/src/main/main.js:32:3637)
    at q (/usr/lib/electron-fiddle/resources/app.asar/dist/src/main/main.js:44:997) {
  code: 'commander.help',
  exitCode: 1,
  nestedError: undefined
}
Electron Fiddle is exiting with code 2

I think Fiddle does not have a --no-sandbox flag, but electron does and that is why it displays a help?

Don't know about the error...

@Crilum
Copy link
Contributor Author

Crilum commented Nov 15, 2021

This is the issue I open in the fiddle repository, for anyone interested:
electron/fiddle#900 (comment)

Edit: The Devs also opened another issue, #902, to talk about the real problem.

@ryanfortner
Copy link
Collaborator

ryanfortner commented Nov 18, 2021

@Crilum your scripts can be updated to v0.27.0

Update to 0.27.0
Update to 0.27.0
Fix wrong link
Copy link
Contributor

@cycool29 cycool29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few improvements.

After these changes, I think this PR is ready to merge.

apps/Electron Fiddle/install-32 Outdated Show resolved Hide resolved
apps/Electron Fiddle/install-32 Outdated Show resolved Hide resolved
apps/Electron Fiddle/install-32 Outdated Show resolved Hide resolved
apps/Electron Fiddle/install-32 Outdated Show resolved Hide resolved
apps/Electron Fiddle/install-64 Outdated Show resolved Hide resolved
apps/Electron Fiddle/install-64 Outdated Show resolved Hide resolved
apps/Electron Fiddle/install-64 Outdated Show resolved Hide resolved
apps/Electron Fiddle/uninstall Outdated Show resolved Hide resolved
apps/Electron Fiddle/uninstall Outdated Show resolved Hide resolved
apps/Electron Fiddle/uninstall Outdated Show resolved Hide resolved
@Crilum
Copy link
Contributor Author

Crilum commented Dec 10, 2021

Yeah, thanks @cycool29. But, Fiddle is an Electron app, and it needs the --no-seccomp-sandbox flag, or whatever it was, to work, but, Fiddle has it's own terminal interface, and it blocks commands from getting to Electron, so this can't be added until electron has fixed that. I have made an issue, but there isn't a lot of progress, as far as I can tell.

@Botspot
Copy link
Owner

Botspot commented Dec 10, 2021

Yeah, thanks @cycool29. But, Fiddle is an Electron app, and it needs the --no-seccomp-sandbox flag, or whatever it was, to work, but, Fiddle has it's own terminal interface, and it blocks commands from getting to Electron, so this can't be added until electron has fixed that. I have made an issue, but there isn't a lot of progress, as far as I can tell.

I encountered this same problem with the Downgrade Chromium app on Bullseye. To work around it, I had to add the --no-seccomp-sandbox flag to all chromium versions under 92. But the latest Chromium on Bullseye doesn't need that flag. Also, Scratch 3 is an electron app made by RPi developers. How did they get past the --no-seccomp-sandbox flag?

@Crilum
Copy link
Contributor Author

Crilum commented Dec 10, 2021

Yeah, thanks @cycool29. But, Fiddle is an Electron app, and it needs the --no-seccomp-sandbox flag, or whatever it was, to work, but, Fiddle has it's own terminal interface, and it blocks commands from getting to Electron, so this can't be added until electron has fixed that. I have made an issue, but there isn't a lot of progress, as far as I can tell.

I encountered this same problem with the Downgrade Chromium app on Bullseye. To work around it, I had to add the --no-seccomp-sandbox flag to all chromium versions under 92. But the latest Chromium on Bullseye doesn't need that flag. Also, Scratch 3 is an electron app made by RPi developers. How did they get past the --no-seccomp-sandbox flag?

I don't know, but Electron uses chromium 7 or 8 (I think), so..

Crilum and others added 9 commits December 10, 2021 16:02
remove unneeded var

Co-authored-by: cycool29 <cycool29@gmail.com>
Co-authored-by: cycool29 <cycool29@gmail.com>
Co-authored-by: cycool29 <cycool29@gmail.com>
Co-authored-by: cycool29 <cycool29@gmail.com>
Co-authored-by: cycool29 <cycool29@gmail.com>
Co-authored-by: cycool29 <cycool29@gmail.com>
Co-authored-by: cycool29 <cycool29@gmail.com>
Co-authored-by: cycool29 <cycool29@gmail.com>
Co-authored-by: cycool29 <cycool29@gmail.com>
@Crilum
Copy link
Contributor Author

Crilum commented Jan 10, 2022

@erickzhao fixed the problem, we just need a build, or a release...

@erickzhao
Copy link

We just finished doing reviews for a bunch of PRs we had in the backlog. I'll try to get a release in for this week. :)

add support for auto updates, and update to latest ver
Add support for auto updates, and update to latest ver
Add update file
@Crilum
Copy link
Contributor Author

Crilum commented Jan 21, 2022

Fiddle has fixed the problem in their latest release (Thanks @erickzhao!), I haven't tested this yet, but should be good to go!

@Crilum
Copy link
Contributor Author

Crilum commented Jan 30, 2022

Ok, I've just got around to actually testing this (on armhf), and it wasn't installing because it thought the version variable was longer then it actually was. Fixed that, and now it works like a charm! I don't even need to use --no-seccomp-sandbox.

I think this is ready for merge, @Botspot.

@ryanfortner
Copy link
Collaborator

lgtm

@ryanfortner
Copy link
Collaborator

@Botspot

@theofficialgman
Copy link
Collaborator

seems like a fun tool. unfortunately it also breaks on bionic/buster due to the electron 18 bug electron/electron#33533, since it downloads the latest release for the "run" button.

@theofficialgman theofficialgman added the Upstream Bug something isn't working that can only be fixed upstream label May 7, 2022
@Crilum
Copy link
Contributor Author

Crilum commented May 8, 2022

Darn.. This has been sitting here for like 5 months... oh well. I guess we'll have to wait for electron. 🤷‍♂️

@theofficialgman theofficialgman removed the Upstream Bug something isn't working that can only be fixed upstream label May 18, 2022
@theofficialgman
Copy link
Collaborator

theofficialgman commented May 18, 2022

ok give this PR just a little while longer, 18.2.4 isn't showing up in-app yet. its just a cache here where 18.2.4 is missing: https://releases.electronjs.org/releases.json should show up in a few hours or something

@theofficialgman
Copy link
Collaborator

alright its there now. @Botspot , I'm merging, please run the clicklist updater

@theofficialgman theofficialgman merged commit 3ceabbb into Botspot:master May 18, 2022
@Crilum Crilum deleted the Electron-Fiddle-PR branch May 19, 2022 16:24
@Crilum
Copy link
Contributor Author

Crilum commented May 19, 2022

Thanks @theofficialgman!

@Botspot
Copy link
Owner

Botspot commented May 19, 2022

Bitly links were created 15 hours ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants