Fix: check only run config.numberFormat on quantitative types (vega…

…#8305)
BradyJ27 · Oct 19, 2023 · 7b8278d · 7b8278d
1 parent 8fef285
commit 7b8278d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/compile/legend/encode.ts b/src/compile/legend/encode.ts
@@ -160,7 +160,13 @@ export function labels(specifiedlabelsSpec: any, {fieldOrDatumDef, model, channe
       formatType,
       config
     });
-  } else if (format === undefined && formatType === undefined && config.customFormatTypes && config.numberFormatType) {
+  } else if (
+    fieldOrDatumDef.type === 'quantitative' &&
+    format === undefined &&
+    formatType === undefined &&
+    config.customFormatTypes &&
+    config.numberFormatType
+  ) {
     text = formatCustomType({
       fieldOrDatumDef,
       field: 'datum.value',

diff --git a/test/compile/legend/encode.test.ts b/test/compile/legend/encode.test.ts
@@ -170,7 +170,7 @@ describe('compile/legend', () => {
   it('returns correct expression for custom format Type from config.numberFormatType', () => {
     const fieldDef: Encoding<string>['color'] = {
       field: 'a',
-      type: 'temporal'
+      type: 'quantitative'
     };
 
     const model = parseUnitModelWithScale({