Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: add extra focus element check #355

Merged
merged 1 commit into from Mar 25, 2024

Conversation

christianvuerings
Copy link
Contributor

@christianvuerings christianvuerings commented Mar 25, 2024

Noticed the following issue when using the Cambio theme:

Cannot read properties of undefined (reading 'focus')

var focusElement = (el) => {
  if (typeof el.focus === "function") {
    el.focus();
  }
};

https://cambly-inc.sentry.io/issues/5098994999/?alert_rule_id=14792676&alert_type=issue&environment=production&notification_uuid=75afccdd-1d2a-42ce-97ea-d90d6d12c677&project=234235&referrer=slack

Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: 4611de1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cambly/syntax-core Minor
@syntax/storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syntax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 4:25pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant