Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: fix close button in Cambio #360

Conversation

christianvuerings
Copy link
Contributor

@christianvuerings christianvuerings commented Mar 26, 2024

@zprong noticed that the x wasn't working on Cambio modals - this fixes that issue

Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: f03e5a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cambly/syntax-core Minor
@syntax/storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syntax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 9:40pm

@christianvuerings christianvuerings force-pushed the iconbutton-make-onclick-required branch 2 times, most recently from 919355c to 16dbdc1 Compare March 26, 2024 21:37
@christianvuerings christianvuerings changed the title IconButton: make onClick required & fix modal close issue Modal: fix close button in Cambio Mar 26, 2024
@christianvuerings christianvuerings merged commit 5826f55 into Cambly:main Mar 26, 2024
10 checks passed
@christianvuerings christianvuerings deleted the iconbutton-make-onclick-required branch March 26, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant