-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leaking CSS styling #11959
Fix leaking CSS styling #11959
Conversation
@jjspace Could you please take a look? |
Thank you for the pull request, @ggetz! ✅ We can confirm we have a CLA on file for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, the element looks the same as before and the code change makes sense. Just had one quick question/suggestion. O
.cesium-viewer-i3s-explorer ul { | ||
list-style-type: none; | ||
} | ||
|
||
.layersList { | ||
.cesium-viewer-i3s-explorer .layersList { | ||
padding: 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be made a bit cleaner using the new ability for nested CSS Selectors.
.cesium-viewer-i3s-explorer {
ul {
list-style-type: none;
}
.layersList {
padding: 0;
}
/* ... */
}
However once again brings up the question of what browsers/environments do we target support for? It was only generally available in the majority of browsers last December as seen on caniuse
Not a reason to hold up this PR but wanted to bring it up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jjspace, I didn't know about these! Let's hold off for now given the amount of time it's been out.
Description
We ID'd some cases where the styling from
packages/widgets/Source/I3SBuildingSceneLayerExplorer/I3SBuildingSceneLayerExplorer.css
was affecting other styling in the page, particularlyul
,input
, and.active
items.This adds a top-level class for the wrapper element and ensures all styling is contained to the wrapper.
Issue number and link
N/A
Testing plan
ul
,input
, and.active
items in a page are not affected.Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my changeI have added or updated unit tests to ensure consistent code coverageI have update the inline documentation, and included code examples where relevant