Skip to content

Commit

Permalink
Migrate front_end/mobile_throttling to devtools_entrypoint
Browse files Browse the repository at this point in the history
R=aerotwist@chromium.org, jacktfranklin@chromium.org

Bug: 1101738
Change-Id: Id3af57fe0c34ad22d75a1bc9b7ed5e02b100f957
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2323625
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
  • Loading branch information
jschfflr authored and Commit Bot committed Jul 29, 2020
1 parent b12601a commit eb118dd
Show file tree
Hide file tree
Showing 11 changed files with 60 additions and 9 deletions.
12 changes: 6 additions & 6 deletions all_devtools_modules.gni
Expand Up @@ -90,12 +90,6 @@ all_devtools_module_sources = [
"media/PlayerPropertiesView.js",
"media/TickingFlameChart.js",
"media/TickingFlameChartHelpers.js",
"mobile_throttling/MobileThrottlingSelector.js",
"mobile_throttling/NetworkPanelIndicator.js",
"mobile_throttling/NetworkThrottlingSelector.js",
"mobile_throttling/ThrottlingManager.js",
"mobile_throttling/ThrottlingPresets.js",
"mobile_throttling/ThrottlingSettingsTab.js",
"network/BinaryResourceView.js",
"network/BlockedURLsPane.js",
"network/EventSourceMessagesView.js",
Expand Down Expand Up @@ -443,6 +437,12 @@ all_typescript_module_sources = [
"javascript_metadata/JavaScriptMetadata.js",
"javascript_metadata/NativeFunctions.js",
"js_main/JsMain.js",
"mobile_throttling/MobileThrottlingSelector.js",
"mobile_throttling/NetworkPanelIndicator.js",
"mobile_throttling/NetworkThrottlingSelector.js",
"mobile_throttling/ThrottlingManager.js",
"mobile_throttling/ThrottlingPresets.js",
"mobile_throttling/ThrottlingSettingsTab.js",
"performance_monitor/PerformanceMonitor.js",
"persistence/Automapping.js",
"persistence/EditFileSystemView.js",
Expand Down
2 changes: 1 addition & 1 deletion devtools_module_entrypoints.gni
Expand Up @@ -64,7 +64,6 @@ devtools_module_entrypoint_sources = [
"media/media-legacy.js",
"media/media.js",
"mobile_throttling/mobile_throttling-legacy.js",
"mobile_throttling/mobile_throttling.js",
"network/network-legacy.js",
"network/network.js",
"node_main/node_main-legacy.js",
Expand Down Expand Up @@ -154,6 +153,7 @@ generated_typescript_entrypoint_sources = [
"$resources_out_dir/javascript_metadata/javascript_metadata.js",
"$resources_out_dir/js_main/js_main.js",
"$resources_out_dir/marked/marked.js",
"$resources_out_dir/mobile_throttling/mobile_throttling.js",
"$resources_out_dir/performance_monitor/performance_monitor.js",
"$resources_out_dir/persistence/persistence.js",
"$resources_out_dir/platform/platform.js",
Expand Down
1 change: 1 addition & 0 deletions front_end/BUILD.gn
Expand Up @@ -34,6 +34,7 @@ group("front_end") {
"issues:bundle",
"javascript_metadata:bundle",
"js_main:bundle",
"mobile_throttling:bundle",
"performance_monitor:bundle",
"persistence:bundle",
"protocol_client:bundle",
Expand Down
31 changes: 31 additions & 0 deletions front_end/mobile_throttling/BUILD.gn
@@ -0,0 +1,31 @@
# Copyright 2020 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

import("../../scripts/build/ninja/devtools_entrypoint.gni")
import("../../scripts/build/ninja/devtools_module.gni")

devtools_module("mobile_throttling") {
sources = [
"MobileThrottlingSelector.js",
"NetworkPanelIndicator.js",
"NetworkThrottlingSelector.js",
"ThrottlingManager.js",
"ThrottlingPresets.js",
"ThrottlingSettingsTab.js",
]

deps = [
"../common:bundle",
"../host:bundle",
"../sdk:bundle",
"../ui:bundle",
]
}

devtools_entrypoint("bundle") {
entrypoint = "mobile_throttling.js"
is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ]

deps = [ ":mobile_throttling" ]
}
3 changes: 3 additions & 0 deletions front_end/mobile_throttling/MobileThrottlingSelector.js
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// @ts-nocheck
// TODO(crbug.com/1011811): Enable TypeScript compiler checks

import * as Common from '../common/common.js';
import * as SDK from '../sdk/sdk.js';

Expand Down
3 changes: 3 additions & 0 deletions front_end/mobile_throttling/NetworkPanelIndicator.js
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// @ts-nocheck
// TODO(crbug.com/1011811): Enable TypeScript compiler checks

import * as Common from '../common/common.js';
import * as SDK from '../sdk/sdk.js';
import * as UI from '../ui/ui.js';
Expand Down
3 changes: 3 additions & 0 deletions front_end/mobile_throttling/NetworkThrottlingSelector.js
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// @ts-nocheck
// TODO(crbug.com/1011811): Enable TypeScript compiler checks

import * as Common from '../common/common.js';
import * as SDK from '../sdk/sdk.js';

Expand Down
3 changes: 3 additions & 0 deletions front_end/mobile_throttling/ThrottlingManager.js
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// @ts-nocheck
// TODO(crbug.com/1011811): Enable TypeScript compiler checks

import * as Common from '../common/common.js';
import * as Host from '../host/host.js';
import * as SDK from '../sdk/sdk.js';
Expand Down
3 changes: 3 additions & 0 deletions front_end/mobile_throttling/ThrottlingPresets.js
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// @ts-nocheck
// TODO(crbug.com/1011811): Enable TypeScript compiler checks

import * as Common from '../common/common.js';
import * as SDK from '../sdk/sdk.js';

Expand Down
3 changes: 3 additions & 0 deletions front_end/mobile_throttling/ThrottlingSettingsTab.js
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// @ts-nocheck
// TODO(crbug.com/1011811): Enable TypeScript compiler checks

import * as Common from '../common/common.js';
import * as SDK from '../sdk/sdk.js'; // eslint-disable-line no-unused-vars
import * as UI from '../ui/ui.js';
Expand Down
5 changes: 3 additions & 2 deletions front_end/mobile_throttling/module.json
Expand Up @@ -68,5 +68,6 @@
],
"resources": [
"throttlingSettingsTab.css"
]
}
],
"skip_rollup": true
}

0 comments on commit eb118dd

Please sign in to comment.