Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to python 3.8 in Dockerfile #65

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Revert to python 3.8 in Dockerfile #65

merged 1 commit into from
Feb 6, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Feb 6, 2024 •
edited

This PR adds | fixes:

This is a temporary fix. In the future we should investigate what's different in python 3.11 that triggers the bug

How to test:

  • Deploy on stage
  • Locally, try to download genes with the command: curl -X 'GET' 'https://schug-stage.scilifelab.se/genes/ensembl_genes/?build=38'

Review:

  • Code approved by HS
  • Tests executed by CR

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@northwestwitch
Copy link
Member Author

Main branch:

image image

This branch:

image image

@northwestwitch northwestwitch added Effort S Effort small Gain L Gain large Urgency L Urgency large labels Feb 6, 2024
henrikstranneheim
henrikstranneheim approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@northwestwitch northwestwitch merged commit 5e1fd52 into main Feb 6, 2024
5 checks passed
@northwestwitch northwestwitch deleted the fix_gunicorn_docker branch February 6, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikstranneheim henrikstranneheim henrikstranneheim approved these changes

Assignees
No one assigned
Labels
Effort S Effort small Gain L Gain large Urgency L Urgency large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuntimeError: can't start new thread
2 participants
@northwestwitch @henrikstranneheim