-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 API: Exchange API Key and Secret for Access and Refresh Tokens on Plugin Upgrade #656
Merged
n7studios
merged 13 commits into
v4-api-oauth-tests
from
v4-api-oauth-exchange-key-for-token
May 17, 2024
Merged
v4 API: Exchange API Key and Secret for Access and Refresh Tokens on Plugin Upgrade #656
n7studios
merged 13 commits into
v4-api-oauth-tests
from
v4-api-oauth-exchange-key-for-token
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exchange-key-for-token
…exchange-key-for-token # Conflicts: # includes/class-convertkit-setup.php
…exchange-key-for-token
…oauth-exchange-key-for-token
6 tasks
…oauth-exchange-key-for-token
…oauth-exchange-key-for-token
noelherrick
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the method name, the word exchange seems to imply that you are getting rid of the old auth credentials, which you are not, so perhaps lookup_access_token_by_api_secret
would be better?
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Automatically exchanges an existing Plugin installation's API Key and Secret for Access and Refresh Tokens when the Plugin is upgraded to
2.5.0
or higher, which introduces using the v4 API with OAuth.Testing
testExchangeAPIKeyAndSecretForAccessToken
: Tests that an existing Plugin installation's API Key and Secret are exchanged for Access and Refresh Tokens, which are then tested as working by making API calls through loading the Plugin's settings screen.Checklist