Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into pnpm issue with version 7.30.1 #99

Closed
ynotdraw opened this issue Mar 23, 2023 · 1 comment · Fixed by #101
Closed

Look into pnpm issue with version 7.30.1 #99

ynotdraw opened this issue Mar 23, 2023 · 1 comment · Fixed by #101

Comments

@ynotdraw
Copy link
Contributor

We needed to pin pnpm to 7.30.0 or else we ran into test issues with our embroider ember-try scenarios #98

For now we've pinned to 7.30.0, but we should most definitely follow up and figure out what broke and how we can go back to always using the latest.
This was referenced Mar 23, 2023
Merged
Closed
@ynotdraw
Copy link
Contributor Author

Filed pnpm/pnpm#6271 as well with pnpm

@ynotdraw ynotdraw mentioned this issue Mar 24, 2023
Merged
ynotdraw added a commit that referenced this issue Mar 24, 2023
@ynotdraw
#99: Try v7.30.2 of pnpm
71b44f9
ynotdraw added a commit that referenced this issue Mar 24, 2023
@ynotdraw
#99: Use latest pnpm again
ca2f3de 
- pnpm/pnpm#6271
- https://github.com/pnpm/pnpm/releases/tag/v7.30.3
ynotdraw added a commit that referenced this issue Mar 27, 2023
@ynotdraw
Merge pull request #101 from CrowdStrike/99-revert-pnpm-back-to-latest
d1e0fb8 
#99: Revert pnpm version pinning to use latest again after 7.30.3 fixes our issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ynotdraw