Fix deps (investigation draft)

[BlueCutOfficial]

cherry-pick #171 to avoid the lint lockfile issue

Build

Babel issues

After fetching the latest master locally and install the dependencies, it's impossible to build the application. The build fails with the following error:

Build Error (broccoli-persistent-filter:Babel > [Babel: @ember/test-helpers]) in @ember/test-helpers/-internal/build-registry.js

[BABEL]: --- PLACEHOLDER PACKAGE ---
This @babel/plugin-proposal-private-property-in-object version is not meant to
be imported. Something is importing
@babel/plugin-proposal-private-property-in-object without declaring it in its
dependencies (or devDependencies) in the package.json file.
Add "@babel/plugin-proposal-private-property-in-object" to your devDependencies
to work around this error. This will make this message go away.
 (While processing: /Users/marine/Desktop/Repos/opensource/dazzlingfugu/ember-reading-time/node_modules/@babel/preset-env/lib/index.js)

(Note that using --frozen-lockfile to try to get the reproducible build from master had no effect.)

[MrChocolatine]

https://github.com/DazzlingFugu/ember-reading-time/actions/runs/8230307831/job/22503306898?pr=174

error ember-cli-babel@8.2.0: The engine "node" is incompatible with this module. Expected version "16.* || 18.* || >= 20". Got "14.21.3"

Similar as #171 (comment) , sadly.

Looks like we don't have other choice to deal with #172 first.

[BlueCutOfficial]

I was just trying to reproduce the isbinaryfile issue and I got stuck with this weird Babel error. Let me know if you also have it locally.

[MrChocolatine]

I was just trying to reproduce the isbinaryfile issue and I got stuck with this weird Babel error. Let me know if you also have it locally.

Unfortunately I am on mobile data, not able to work properly, just reviewing my notifications.

[BlueCutOfficial]

Yes sure, I didn't mean right away :)
isbinaryfile comes from ember-cli apparently but I was never forced to drop Node 16 before, even in addons using a modern Ember version. What is the actual meaning of the Floating dependencies job? What are we supposed to use it for?

[MrChocolatine]

Yes sure, I didn't mean right away :) isbinaryfile comes from ember-cli apparently but I was never forced to drop Node 16 before, even in addons using a modern Ember version. What is the actual meaning of the Floating dependencies job? What are we supposed to use it for?

it is creating a scenario where dependencies are supposed to be installed in a more "relaxed version" as the command does not read or generate a lockfile:
https://classic.yarnpkg.com/lang/en/docs/cli/install/#toc-yarn-install-no-lockfile

[BlueCutOfficial]

I understand what the scenario does, my question was more about the why. I don't have a clear opinion about how this job is supposed to help us with maintenance yet, and it's a bit curious that isbinaryfile "^5.0.0" is currently present in our yarn.lock but doesn't impact the other jobs. Or is it about a dependency of this thing? I don't know.