[react] [react-dom] Add unstable prefix to experimental APIs

[leonardodino]

updates existing experimental.d.ts types to match recent changes to prefixes.

PR: facebook/react#18825

---

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: Add unstable prefix to experimental APIs facebook/react#18825
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• Include tests for your changes
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

[typescript-bot]

@leonardodino Thank you for submitting this PR!

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

• ✅ No merge conflicts
• ❌ Continuous integration tests have passed
• ✅ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 44564,
  "author": "leonardodino",
  "owners": [
    "MartynasZilinskas",
    "theruther4d",
    "Jessidhia",
    "johnnyreilly",
    "bbenezech",
    "pzavolinsky",
    "digiguru",
    "ericanderson",
    "DovydasNavickas",
    "guilhermehubner",
    "ferdaber",
    "jrakotoharisoa",
    "pascaloliv",
    "hotell",
    "franklixuefei",
    "saranshkataria",
    "lukyth",
    "eps1lon",
    "zieka",
    "dancerphil",
    "dimitropoulos",
    "disjukr",
    "vhfmag"
  ],
  "dangerLevel": "MultiplePackagesEdited",
  "headCommitAbbrOid": "dce5b2b",
  "headCommitOid": "dce5b2b992d2bc2d5a92bc89ca7f1f2aa859f4db",
  "mergeIsRequested": false,
  "stalenessInDays": 2,
  "lastCommitDate": "2020-05-08T04:33:38.000Z",
  "lastCommentDate": "2020-05-08T07:27:52.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44564/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "anyPackageIsNew": false,
  "packages": [
    "react-dom",
    "react"
  ],
  "files": [
    {
      "filePath": "types/react-dom/experimental.d.ts",
      "kind": "definition",
      "package": "react-dom"
    },
    {
      "filePath": "types/react-dom/test/experimental-tests.tsx",
      "kind": "test",
      "package": "react-dom"
    },
    {
      "filePath": "types/react/experimental.d.ts",
      "kind": "definition",
      "package": "react"
    },
    {
      "filePath": "types/react/test/experimental.tsx",
      "kind": "test",
      "package": "react"
    }
  ],
  "hasDismissedReview": false,
  "travisResult": "fail",
  "travisUrl": "https://travis-ci.org/github/DefinitelyTyped/DefinitelyTyped/builds/684543487?utm_source=github_status&utm_medium=notification",
  "lastReviewDate": "2020-05-11T01:20:19.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 7,
  "isChangesRequested": false
}

[typescript-bot]

🔔 @MartynasZilinskas @theruther4d @Jessidhia @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

react-dom/v*

Comparison details for react-dom/* 📊

	master	#44564	diff
Batch compilation
Memory usage (MiB)	109.4	112.0	+2.4%
Type count	24825	24825	0%
Assignability cache size	69318	69318	0%
Language service
Samples taken	434	434	0%
Identifiers in tests	434	434	0%
getCompletionsAtPosition
Mean duration (ms)	560.5	554.7	-1.0%
Mean CV	8.8%	8.8%
Worst duration (ms)	733.2	763.8	+4.2%
Worst identifier	TestComponent	rootElement
getQuickInfoAtPosition
Mean duration (ms)	555.3	547.7	-1.4%
Mean CV	8.4%	8.1%	-3.4%
Worst duration (ms)	728.2	728.1	0.0%
Worst identifier	createElement	createElement

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

react/v*

Comparison details for react/* 📊

	master	#44564	diff
Batch compilation
Memory usage (MiB)	120.7	121.3	+0.6%
Type count	41436	41436	0%
Assignability cache size	64480	64480	0%
Language service
Samples taken	2236	2236	0%
Identifiers in tests	2764	2764	0%
getCompletionsAtPosition
Mean duration (ms)	360.0	360.4	+0.1%
Mean CV	7.6%	7.5%
Worst duration (ms)	2386.6	2352.7	-1.4%
Worst identifier	memoized4Ref	memoized4Ref
getQuickInfoAtPosition
Mean duration (ms)	355.8	356.0	+0.1%
Mean CV	7.4%	7.4%	-0.2%
Worst duration (ms)	1974.6	1895.7	-4.0%
Worst identifier	ref	ref

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[dimitropoulos]

good catch, thanks!

[Jessidhia]

This sounds like a bug in the test runner:

Error in react-bootstrap/undefined
Error: ENOENT: no such file or directory, open '/home/travis/build/DefinitelyTyped/DefinitelyTyped/types/react-bootstrap/undefined/index.d.ts'

The other test failures are unrelated to the changes.

The changes are already available on the npm experimental tag

[typescript-bot]

I just published @types/react@16.9.35 to npm.

[typescript-bot]

I just published @types/react-dom@16.9.8 to npm.