New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest): Bump dependencies #45603
fix(jest): Bump dependencies #45603
Conversation
@ExE-Boss Thank you for submitting this PR! This is a live comment which I will keep updated. Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 31 days — it is considered abandoned! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 45603,
"author": "ExE-Boss",
"owners": [
"NoHomey",
"jwbay",
"asvetliakov",
"alexjoverm",
"epicallan",
"ikatyang",
"wsmd",
"JamieMason",
"douglasduteil",
"ahnpnl",
"joshuakgoldberg",
"UselessPickles",
"r3nya",
"hotell",
"sebald",
"andys8",
"antoinebrault",
"gstamac",
"ExE-Boss",
"quassnoi",
"Belco90",
"tonyhallett",
"ycmjason",
"devanshj",
"pawfa",
"regevbr"
],
"dangerLevel": "ScopedAndConfiguration",
"headCommitAbbrOid": "0871812",
"headCommitOid": "087181289f318d868a26f9bc8fb8bd683cbc1b42",
"mergeIsRequested": false,
"stalenessInDays": 31,
"lastPushDate": "2020-06-26T13:23:23.000Z",
"lastCommentDate": "2020-07-01T06:05:22.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45603/files",
"hasMergeConflict": false,
"authorIsOwner": true,
"isFirstContribution": false,
"popularityLevel": "Critical",
"anyPackageIsNew": false,
"packages": [
"jest"
],
"files": [
{
"path": "types/jest/index.d.ts",
"kind": "definition",
"package": "jest"
},
{
"path": "types/jest/jest-tests.ts",
"kind": "test",
"package": "jest"
},
{
"path": "types/jest/package.json",
"kind": "package-meta",
"package": "jest",
"suspect": "edited"
},
{
"path": "types/jest/ts3.2/index.d.ts",
"kind": "definition",
"package": "jest"
},
{
"path": "types/jest/ts3.2/jest-tests.ts",
"kind": "test",
"package": "jest"
},
{
"path": "types/jest/ts3.2/tsconfig.json",
"kind": "package-meta",
"package": "jest",
"suspect": "couldn't fetch contents"
},
{
"path": "types/jest/ts3.2/tslint.json",
"kind": "package-meta",
"package": "jest",
"suspect": "couldn't fetch contents"
},
{
"path": "types/jest/tsconfig.json",
"kind": "package-meta",
"package": "jest",
"suspect": "changes outside of \"files\" list"
}
],
"hasDismissedReview": false,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/087181289f318d868a26f9bc8fb8bd683cbc1b42/checks?check_suite_id=845498657",
"lastReviewDate": "2020-07-01T06:05:22.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @JoshuaKGoldberg @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr — please review this PR in the next few days. Be sure to explicitly select |
@ExE-Boss The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
@ExE-Boss The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
@ExE-Boss The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Hi there, any updates? |
@@ -29,7 +29,7 @@ | |||
// Regev Brody <https://github.com/regevbr> | |||
// Mark Skelton <https://github.com/mskelton> | |||
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped | |||
// TypeScript Version: 3.1 | |||
// TypeScript Version: 3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think TypeScript Version
can be 3.2, is not it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because the dependencies use import type
, which is only supported since TypeScript 3.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ExE-Boss is that whats blocking this PR, or was it abandoned for another reason?
I've noticed in my dependency tree I've got some duplication caused by @types/jest
being at the top of the tree: it causes some jest 25 packages to pulled in, which causes jest to duplicate itself in a bunch of places since I'm using 26.
I'm happy to do the dependency update, but wanted to check if this was the blocker before getting started :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just recreated this PR:
#47545
@ExE-Boss I haven't seen any activity on this PR in more than 3 weeks, and this PR currently has problems that prevent it from being merged. The PR will be closed in a week if the issues aren't addressed. |
@ExE-Boss To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you! |
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.This should’ve been done as part of #45234.