Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest): Bump dependencies #45603

Closed

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jun 20, 2020

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

This should’ve been done as part of #45234.

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Jun 20, 2020
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jun 20, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 20, 2020

@ExE-Boss Thank you for submitting this PR!

This is a live comment which I will keep updated.

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have passed
  • ❌ A DT maintainer needs to approve changes which affect module config files
    • jest/package.json: edited
    • jest/ts3.2/tsconfig.json: couldn't fetch contents
    • jest/ts3.2/tslint.json: couldn't fetch contents
    • jest/tsconfig.json: changes outside of "files" list

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 45603,
  "author": "ExE-Boss",
  "owners": [
    "NoHomey",
    "jwbay",
    "asvetliakov",
    "alexjoverm",
    "epicallan",
    "ikatyang",
    "wsmd",
    "JamieMason",
    "douglasduteil",
    "ahnpnl",
    "joshuakgoldberg",
    "UselessPickles",
    "r3nya",
    "hotell",
    "sebald",
    "andys8",
    "antoinebrault",
    "gstamac",
    "ExE-Boss",
    "quassnoi",
    "Belco90",
    "tonyhallett",
    "ycmjason",
    "devanshj",
    "pawfa",
    "regevbr"
  ],
  "dangerLevel": "ScopedAndConfiguration",
  "headCommitAbbrOid": "0871812",
  "headCommitOid": "087181289f318d868a26f9bc8fb8bd683cbc1b42",
  "mergeIsRequested": false,
  "stalenessInDays": 31,
  "lastPushDate": "2020-06-26T13:23:23.000Z",
  "lastCommentDate": "2020-07-01T06:05:22.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45603/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "anyPackageIsNew": false,
  "packages": [
    "jest"
  ],
  "files": [
    {
      "path": "types/jest/index.d.ts",
      "kind": "definition",
      "package": "jest"
    },
    {
      "path": "types/jest/jest-tests.ts",
      "kind": "test",
      "package": "jest"
    },
    {
      "path": "types/jest/package.json",
      "kind": "package-meta",
      "package": "jest",
      "suspect": "edited"
    },
    {
      "path": "types/jest/ts3.2/index.d.ts",
      "kind": "definition",
      "package": "jest"
    },
    {
      "path": "types/jest/ts3.2/jest-tests.ts",
      "kind": "test",
      "package": "jest"
    },
    {
      "path": "types/jest/ts3.2/tsconfig.json",
      "kind": "package-meta",
      "package": "jest",
      "suspect": "couldn't fetch contents"
    },
    {
      "path": "types/jest/ts3.2/tslint.json",
      "kind": "package-meta",
      "package": "jest",
      "suspect": "couldn't fetch contents"
    },
    {
      "path": "types/jest/tsconfig.json",
      "kind": "package-meta",
      "package": "jest",
      "suspect": "changes outside of \"files\" list"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/087181289f318d868a26f9bc8fb8bd683cbc1b42/checks?check_suite_id=845498657",
  "lastReviewDate": "2020-07-01T06:05:22.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 20, 2020

🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @JoshuaKGoldberg @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jun 20, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Jun 20, 2020
@typescript-bot
Copy link
Contributor

@ExE-Boss The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Jun 20, 2020
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jun 20, 2020
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jun 20, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Jun 20, 2020
@typescript-bot
Copy link
Contributor

@ExE-Boss The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #45603 diff
Batch compilation
Memory usage (MiB) 81.6 78.1 -4.3%
Type count 14710 15325 +4%
Assignability cache size 4812 4836 0%
Language service
Samples taken 2563 2571 0%
Identifiers in tests 2563 2571 0%
getCompletionsAtPosition
    Mean duration (ms) 349.7 377.2 +7.9%
    Mean CV 8.4% 8.2%
    Worst duration (ms) 498.1 509.5 +2.3%
    Worst identifier jasmine not
getQuickInfoAtPosition
    Mean duration (ms) 350.7 377.4 +7.6%
    Mean CV 8.6% 8.4% -2.3%
    Worst duration (ms) 478.2 489.6 +2.4%
    Worst identifier each args

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Check Config Changes a module config files labels Jun 20, 2020
@typescript-bot
Copy link
Contributor

@ExE-Boss The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@L2jLiga
Copy link
Contributor

L2jLiga commented Jul 1, 2020

Hi there, any updates?

@@ -29,7 +29,7 @@
// Regev Brody <https://github.com/regevbr>
// Mark Skelton <https://github.com/mskelton>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// TypeScript Version: 3.1
// TypeScript Version: 3.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think TypeScript Version can be 3.2, is not it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because the dependencies use import type, which is only supported since TypeScript 3.4.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ExE-Boss is that whats blocking this PR, or was it abandoned for another reason?

I've noticed in my dependency tree I've got some duplication caused by @types/jest being at the top of the tree: it causes some jest 25 packages to pulled in, which causes jest to duplicate itself in a bunch of places since I'm using 26.

I'm happy to do the dependency update, but wanted to check if this was the blocker before getting started :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just recreated this PR:
#47545

@typescript-bot
Copy link
Contributor

@ExE-Boss I haven't seen any activity on this PR in more than 3 weeks, and this PR currently has problems that prevent it from being merged. The PR will be closed in a week if the issues aren't addressed.

@typescript-bot typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Aug 2, 2020
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board Aug 2, 2020
@typescript-bot
Copy link
Contributor

@ExE-Boss To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned This PR had no activity for a long time, and is considered abandoned Author is Owner The author of this PR is a listed owner of the package. Check Config Changes a module config files Critical package Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. The CI failed When GH Actions fails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants