Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest): remove require.requireActual and require.requireMock #46271

Merged
merged 4 commits into from Jul 31, 2020

Conversation

Calvin-LL
Copy link
Contributor

@Calvin-LL Calvin-LL commented Jul 22, 2020

require.requireActual and require.requireMock have been removed by jestjs/jest#9854
this pull request remove the type definitions

@typescript-bot typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR Critical package labels Jul 22, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 22, 2020

@CoolCyberBrain Thank you for submitting this PR!

This is a live comment which I will keep updated.

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 46271,
  "author": "CoolCyberBrain",
  "owners": [
    "NoHomey",
    "jwbay",
    "asvetliakov",
    "alexjoverm",
    "epicallan",
    "ikatyang",
    "wsmd",
    "JamieMason",
    "douglasduteil",
    "ahnpnl",
    "joshuakgoldberg",
    "UselessPickles",
    "r3nya",
    "hotell",
    "sebald",
    "andys8",
    "antoinebrault",
    "gstamac",
    "ExE-Boss",
    "quassnoi",
    "Belco90",
    "tonyhallett",
    "ycmjason",
    "devanshj",
    "pawfa",
    "regevbr"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "cec7612",
  "headCommitOid": "cec76128a7d8fb06ae0f364c79b8197d06128e6f",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-07-23T17:26:55.000Z",
  "lastCommentDate": "2020-07-31T04:46:27.000Z",
  "maintainerBlessed": true,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46271/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "anyPackageIsNew": false,
  "packages": [
    "jest"
  ],
  "files": [
    {
      "path": "types/jest/index.d.ts",
      "kind": "definition",
      "package": "jest"
    },
    {
      "path": "types/jest/jest-tests.ts",
      "kind": "test",
      "package": "jest"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-07-31T04:35:00.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 22, 2020

🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @JoshuaKGoldberg @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed Where is GH Actions? GH Actions didn't give a response to this PR labels Jul 22, 2020
@typescript-bot typescript-bot moved this from Other to Needs Author Action in New Pull Request Status Board Jul 22, 2020
@typescript-bot
Copy link
Contributor

@CoolCyberBrain The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@Calvin-LL
Copy link
Contributor Author

Calvin-LL commented Jul 22, 2020

The linting errors are unrelated to the changes. Caused by #46072 and #46073. I made a pull request to fix it #46272 please merge that first.

@Calvin-LL Calvin-LL changed the title [jest] remove require.requireActual and require.requireMock fix(jest): remove require.requireActual and require.requireMock Jul 22, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #46271 diff
Batch compilation
Memory usage (MiB) 83.7 85.4 +2.0%
Type count 14837 14834 0%
Assignability cache size 4886 4886 0%
Language service
Samples taken 2700 2694 0%
Identifiers in tests 2700 2694 0%
getCompletionsAtPosition
    Mean duration (ms) 423.3 422.2 -0.3%
    Mean CV 7.3% 7.0%
    Worst duration (ms) 578.0 573.4 -0.8%
    Worst identifier jest fakeDefault
getQuickInfoAtPosition
    Mean duration (ms) 423.5 423.0 -0.1%
    Mean CV 7.5% 7.3% -3.1%
    Worst duration (ms) 612.8 573.9 -6.3%
    Worst identifier expect color

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jul 22, 2020
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Jul 23, 2020
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jul 23, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jul 23, 2020
@Calvin-LL
Copy link
Contributor Author

#46272 has been resolved. This should be good now.

@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Jul 23, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jul 23, 2020
@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Jul 23, 2020
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Jul 31, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Jul 31, 2020
@typescript-bot
Copy link
Contributor

@CoolCyberBrain Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@NoHomey, @jwbay, @asvetliakov, @alexjoverm, @epicallan, @ikatyang, @wsmd, @JamieMason, @douglasduteil, @ahnpnl, @JoshuaKGoldberg, @UselessPickles, @r3nya, @Hotell, @sebald, @andys8, @antoinebrault, @gstamac, @ExE-Boss, @quassnoi, @Belco90, @tonyhallett, @ycmjason, @devanshj, @pawfa, @regevbr: you can do this too.)

@Calvin-LL
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jul 31, 2020
@typescript-bot typescript-bot merged commit 74fc050 into DefinitelyTyped:master Jul 31, 2020
@typescript-bot
Copy link
Contributor

I just published @types/jest@26.0.8 to npm.

@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Aug 1, 2020
danielrearden pushed a commit to danielrearden/DefinitelyTyped that referenced this pull request Sep 22, 2020
…tual` and `require.requireMock` by @CoolCyberBrain

* remove NodeRequire interface

* remove nodeRequire test

* remove line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants