Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(jest): fix linting error #46272

Closed
wants to merge 1 commit into from

Conversation

Calvin-LL
Copy link
Contributor

@Calvin-LL Calvin-LL commented Jul 22, 2020

While working on #46271, I noticed that #46072 and #46073 are merged at the same time without rebasing, one added a linting rule the other one violates. This pull request fixes that.

@typescript-bot typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR Critical package Untested Change This PR does not touch tests labels Jul 22, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 22, 2020

@CoolCyberBrain Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

  • ❌ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 46272,
  "author": "CoolCyberBrain",
  "owners": [
    "NoHomey",
    "jwbay",
    "asvetliakov",
    "alexjoverm",
    "epicallan",
    "ikatyang",
    "wsmd",
    "JamieMason",
    "douglasduteil",
    "ahnpnl",
    "joshuakgoldberg",
    "UselessPickles",
    "r3nya",
    "hotell",
    "sebald",
    "andys8",
    "antoinebrault",
    "gstamac",
    "ExE-Boss",
    "quassnoi",
    "Belco90",
    "tonyhallett",
    "ycmjason",
    "devanshj",
    "pawfa",
    "regevbr",
    "mskelton"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "c569607",
  "headCommitOid": "c569607c218cf686fc765f114a9b38e2815a4539",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastPushDate": "2020-07-22T20:48:36.000Z",
  "lastCommentDate": "2020-07-23T10:38:00.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46272/files",
  "hasMergeConflict": true,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "anyPackageIsNew": false,
  "packages": [
    "jest"
  ],
  "files": [
    {
      "path": "types/jest/index.d.ts",
      "kind": "definition",
      "package": "jest"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-07-23T00:17:39.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @JoshuaKGoldberg @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr @mskelton — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot removed the Where is GH Actions? GH Actions didn't give a response to this PR label Jul 22, 2020
@typescript-bot typescript-bot moved this from Other to Needs Maintainer Review in New Pull Request Status Board Jul 22, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #46272 diff
Batch compilation
Memory usage (MiB) 84.1 83.8 -0.4%
Type count 14837 14837 0%
Assignability cache size 4886 4886 0%
Language service
Samples taken 2700 2700 0%
Identifiers in tests 2700 2700 0%
getCompletionsAtPosition
    Mean duration (ms) 408.8 411.8 +0.7%
    Mean CV 7.8% 8.3%
    Worst duration (ms) 569.4 590.7 +3.7%
    Worst identifier Promise lastCalledWith
getQuickInfoAtPosition
    Mean duration (ms) 409.0 411.9 +0.7%
    Mean CV 8.2% 8.6% +4.7%
    Worst duration (ms) 600.0 556.5 -7.3%
    Worst identifier expect value2

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jul 22, 2020
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jul 23, 2020
@devanshj
Copy link
Contributor

devanshj commented Jul 23, 2020

CanShould be superseded by #46286

@devanshj
Copy link
Contributor

@CoolCyberBrain #46286 is merged so this can be closed and you can rebase your PRs, thanks!

@typescript-bot typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Jul 23, 2020
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Author Action in New Pull Request Status Board Jul 23, 2020
@typescript-bot
Copy link
Contributor

@CoolCyberBrain Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@Calvin-LL Calvin-LL closed this Jul 23, 2020
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants