feat(react): Add unstable_useOpaqueIdentifier

[eps1lon]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:
  • PR that introduced the version: Add useOpaqueIdentifier Hook facebook/react#17322
• [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• Include tests for your changes
• [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

[typescript-bot]

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• react on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 46692,
  "author": "eps1lon",
  "owners": [
    "johnnyreilly",
    "bbenezech",
    "pzavolinsky",
    "digiguru",
    "ericanderson",
    "DovydasNavickas",
    "theruther4d",
    "guilhermehubner",
    "ferdaber",
    "jrakotoharisoa",
    "pascaloliv",
    "hotell",
    "franklixuefei",
    "Jessidhia",
    "saranshkataria",
    "lukyth",
    "eps1lon",
    "zieka",
    "dancerphil",
    "dimitropoulos",
    "disjukr",
    "vhfmag",
    "hellatan"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "9066a7d",
  "headCommitOid": "9066a7dc590dfd5072a5c8c13bf6981034925cde",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastPushDate": "2020-08-31T07:56:29.000Z",
  "lastCommentDate": "2020-08-31T07:56:59.000Z",
  "maintainerBlessed": true,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46692/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "newPackages": [],
  "packages": [
    "react"
  ],
  "files": [
    {
      "path": "types/react/experimental.d.ts",
      "kind": "definition",
      "package": "react"
    },
    {
      "path": "types/react/test/experimental.tsx",
      "kind": "test",
      "package": "react"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-08-31T14:21:49.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

[typescript-bot]

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#46692	diff
Batch compilation
Memory usage (MiB)	129.6	131.8	+1.7%
Type count	35619	35642	0%
Assignability cache size	8532	8558	0%
Language service
Samples taken	2313	2313	0%
Identifiers in tests	2851	2873	+1%
getCompletionsAtPosition
Mean duration (ms)	321.8	321.8	0.0%
Mean CV	8.0%	8.0%
Worst duration (ms)	1237.4	1180.4	-4.6%
Worst identifier	x	props
getQuickInfoAtPosition
Mean duration (ms)	319.4	319.5	0.0%
Mean CV	8.1%	8.2%	+1.0%
Worst duration (ms)	1009.2	1039.3	+3.0%
Worst identifier	ref	ref

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[ferdaber]

I think this makes sense. Just FYI that I believe branding symbols automatically get exported out regardless of modifiers in order for the compiler to actually work, so consumers will have access to the unique symbol even though there’s no export declaration on it.

[eps1lon]

Just FYI that I believe branding symbols automatically get exported out regardless of modifiers in order for the compiler to actually work, so consumers will have access to the unique symbol even though there’s no export declaration on it.

Added an additional guard: 9066a7d

[typescript-bot]

@ferdaber Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[typescript-bot]

I just published @types/react@16.9.49 to npm.