New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@types/jest]: bump dependencies to v26 #47545
Conversation
@L2jLiga Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 47545,
"author": "L2jLiga",
"owners": [
"NoHomey",
"jwbay",
"asvetliakov",
"alexjoverm",
"epicallan",
"ikatyang",
"wsmd",
"JamieMason",
"douglasduteil",
"ahnpnl",
"joshuakgoldberg",
"UselessPickles",
"r3nya",
"hotell",
"sebald",
"andys8",
"antoinebrault",
"gstamac",
"ExE-Boss",
"quassnoi",
"Belco90",
"tonyhallett",
"ycmjason",
"devanshj",
"pawfa",
"regevbr"
],
"dangerLevel": "ScopedAndConfiguration",
"headCommitAbbrOid": "03fc4ff",
"headCommitOid": "03fc4ff17e03a3492008b36d0e914a4dd5acef34",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastPushDate": "2020-09-13T07:03:30.000Z",
"lastCommentDate": "2020-09-13T07:03:30.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47545/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Critical",
"newPackages": [],
"packages": [
"jest"
],
"files": [
{
"path": "types/jest/index.d.ts",
"kind": "definition",
"package": "jest"
},
{
"path": "types/jest/jest-tests.ts",
"kind": "test",
"package": "jest"
},
{
"path": "types/jest/package.json",
"kind": "package-meta",
"package": "jest",
"suspect": "edited"
},
{
"path": "types/jest/ts3.1/index.d.ts",
"kind": "definition",
"package": "jest"
},
{
"path": "types/jest/ts3.1/jest-tests.ts",
"kind": "test",
"package": "jest"
},
{
"path": "types/jest/ts3.1/tsconfig.json",
"kind": "package-meta",
"package": "jest",
"suspect": "couldn't fetch contents"
},
{
"path": "types/jest/ts3.1/tslint.json",
"kind": "package-meta",
"package": "jest",
"suspect": "couldn't fetch contents"
}
],
"hasDismissedReview": false,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/03fc4ff17e03a3492008b36d0e914a4dd5acef34/checks?check_suite_id=1184606607",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @JoshuaKGoldberg @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr — please review this PR in the next few days. Be sure to explicitly select |
@L2jLiga The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
@L2jLiga The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Closing this for now, have to check |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we?
Looks like there were a couple significant differences—take a look at worst-case duration for getting quick info at a position to make sure everything looks ok. |
I guess this means we're locked in to the old dependencies until 2022 😬 |
We can bump minimal TS version everywhere to 3.8.. i mean dependable types |
I don't mind doing that if it's ok with DT - I think it's fair to say that while DT doesn't drop support for <3.8 until 2022, |
Jest v26 requires TS 3.8+ (see jestjs/jest#9823).
Changed
index.d.ts
andts3.1/index.d.ts
ts3.1
Checklist
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).