Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/jest]: bump dependencies to v26 #47545

Closed
wants to merge 1 commit into from
Closed

[@types/jest]: bump dependencies to v26 #47545

wants to merge 1 commit into from

Conversation

L2jLiga
Copy link
Contributor

@L2jLiga L2jLiga commented Sep 13, 2020

Jest v26 requires TS 3.8+ (see jestjs/jest#9823).

Changed

  • updated dependencies
  • merged typings from index.d.ts and ts3.1/index.d.ts
  • removed ts3.1
  • set minimum TypeScript version to 3.8

Checklist

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes: chore: require minimum typescript@3.8 jestjs/jest#9823
  • Include tests for your changes

@L2jLiga L2jLiga mentioned this pull request Sep 13, 2020
10 tasks
@typescript-bot typescript-bot added Critical package Check Config Changes a module config files labels Sep 13, 2020
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Sep 13, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 13, 2020

@L2jLiga Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have passed
  • ❌ A DT maintainer needs to approve changes which affect module config files
    • jest/package.json: edited
    • jest/ts3.1/tsconfig.json: couldn't fetch contents
    • jest/ts3.1/tslint.json: couldn't fetch contents

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 47545,
  "author": "L2jLiga",
  "owners": [
    "NoHomey",
    "jwbay",
    "asvetliakov",
    "alexjoverm",
    "epicallan",
    "ikatyang",
    "wsmd",
    "JamieMason",
    "douglasduteil",
    "ahnpnl",
    "joshuakgoldberg",
    "UselessPickles",
    "r3nya",
    "hotell",
    "sebald",
    "andys8",
    "antoinebrault",
    "gstamac",
    "ExE-Boss",
    "quassnoi",
    "Belco90",
    "tonyhallett",
    "ycmjason",
    "devanshj",
    "pawfa",
    "regevbr"
  ],
  "dangerLevel": "ScopedAndConfiguration",
  "headCommitAbbrOid": "03fc4ff",
  "headCommitOid": "03fc4ff17e03a3492008b36d0e914a4dd5acef34",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastPushDate": "2020-09-13T07:03:30.000Z",
  "lastCommentDate": "2020-09-13T07:03:30.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47545/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "newPackages": [],
  "packages": [
    "jest"
  ],
  "files": [
    {
      "path": "types/jest/index.d.ts",
      "kind": "definition",
      "package": "jest"
    },
    {
      "path": "types/jest/jest-tests.ts",
      "kind": "test",
      "package": "jest"
    },
    {
      "path": "types/jest/package.json",
      "kind": "package-meta",
      "package": "jest",
      "suspect": "edited"
    },
    {
      "path": "types/jest/ts3.1/index.d.ts",
      "kind": "definition",
      "package": "jest"
    },
    {
      "path": "types/jest/ts3.1/jest-tests.ts",
      "kind": "test",
      "package": "jest"
    },
    {
      "path": "types/jest/ts3.1/tsconfig.json",
      "kind": "package-meta",
      "package": "jest",
      "suspect": "couldn't fetch contents"
    },
    {
      "path": "types/jest/ts3.1/tslint.json",
      "kind": "package-meta",
      "package": "jest",
      "suspect": "couldn't fetch contents"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/03fc4ff17e03a3492008b36d0e914a4dd5acef34/checks?check_suite_id=1184606607",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @JoshuaKGoldberg @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Sep 13, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Sep 13, 2020
@typescript-bot
Copy link
Contributor

@L2jLiga The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Sep 13, 2020
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Sep 13, 2020
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Sep 13, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Sep 13, 2020
@typescript-bot
Copy link
Contributor

@L2jLiga The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@L2jLiga
Copy link
Contributor Author

L2jLiga commented Sep 13, 2020

Closing this for now, have to check expect-puppeteer types and find workaround for Expect.addSnapshotSerializer and MatcherUtils.utils.diff

@L2jLiga L2jLiga closed this Sep 13, 2020
@L2jLiga L2jLiga deleted the feature/update-jest branch September 13, 2020 07:44
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board Sep 13, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

master #47545 diff
Batch compilation
Memory usage (MiB) 79.7 85.8 +7.6%
Type count 11872 15315 +29%
Assignability cache size 3723 4839 +30%
Language service
Samples taken 18 2610 +14400%
Identifiers in tests 18 2610 +14400%
getCompletionsAtPosition
    Mean duration (ms) 355.8 359.9 +1.1%
    Mean CV 12.3% 8.1%
    Worst duration (ms) 411.9 474.8 +15.3%
    Worst identifier expect toHaveProperty
getQuickInfoAtPosition
    Mean duration (ms) 343.1 360.3 +5.0%
    Mean CV 10.2% 8.3% -18.6%
    Worst duration (ms) 376.9 471.2 +25.0% 🔸
    Worst identifier BigInt Case

Looks like there were a couple significant differences—take a look at worst-case duration for getting quick info at a position to make sure everything looks ok.

@typescript-bot typescript-bot added the Perf: Worse typescript-bot determined that this PR has a negative impact on compilation performance. label Sep 13, 2020
@G-Rath
Copy link
Contributor

G-Rath commented Sep 26, 2020

I guess this means we're locked in to the old dependencies until 2022 😬

@L2jLiga
Copy link
Contributor Author

L2jLiga commented Sep 26, 2020

We can bump minimal TS version everywhere to 3.8.. i mean dependable types

@G-Rath
Copy link
Contributor

G-Rath commented Sep 26, 2020

I don't mind doing that if it's ok with DT - I think it's fair to say that while DT doesn't drop support for <3.8 until 2022, @types/jest & co can drop it now as it's matching the min supported by jest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Check Config Changes a module config files Critical package Perf: Worse typescript-bot determined that this PR has a negative impact on compilation performance. The CI failed When GH Actions fails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants