Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serverless): update config properties #51130

Merged
merged 1 commit into from Mar 7, 2021

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Feb 8, 2021

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Feb 8, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 8, 2021

@G-Rath Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 18 days — it is still unreviewed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 51130,
  "author": "G-Rath",
  "headCommitOid": "6357935a79bc97f61b1ce15a27a7c83bbe44d2d5",
  "lastPushDate": "2021-02-16T18:53:58.000Z",
  "lastActivityDate": "2021-02-16T18:53:58.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "serverless",
      "kind": "edit",
      "files": [
        {
          "path": "types/serverless/plugins/aws/provider/awsProvider.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/serverless/serverless-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "hassankhan",
        "JonathanWilbur",
        "a-pavlenko",
        "fredericbarthelet",
        "bryan-hunter",
        "thomasaribart"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @hassankhan @JonathanWilbur @a-pavlenko @fredericbarthelet @bryan-hunter @ThomasAribart — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Feb 8, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Feb 8, 2021
@typescript-bot
Copy link
Contributor

@G-Rath The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #51130 diff
Batch compilation
Memory usage (MiB) 42.5 46.0 +8.3%
Type count 3217 3532 +10%
Assignability cache size 316 346 +9%
Language service
Samples taken 568 591 +4%
Identifiers in tests 568 591 +4%
getCompletionsAtPosition
    Mean duration (ms) 97.3 99.6 +2.4%
    Mean CV 14.4% 14.3%
    Worst duration (ms) 160.3 148.2 -7.6%
    Worst identifier Type Type
getQuickInfoAtPosition
    Mean duration (ms) 102.5 102.5 0.0%
    Mean CV 11.8% 12.2%
    Worst duration (ms) 171.3 149.4 -12.8%
    Worst identifier testFunction events

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Feb 8, 2021
@typescript-bot
Copy link
Contributor

@G-Rath The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

@G-Rath The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

@G-Rath The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Feb 8, 2021
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Feb 8, 2021
@G-Rath G-Rath force-pushed the serverless-update-types branch 2 times, most recently from 16830bb to 7a02a89 Compare February 16, 2021 18:47
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Feb 16, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Feb 16, 2021
@typescript-bot
Copy link
Contributor

@G-Rath The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Feb 17, 2021
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Feb 17, 2021
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Feb 27, 2021
@typescript-bot
Copy link
Contributor

Re-ping @hassankhan, @JonathanWilbur, @a-pavlenko, @fredericbarthelet, @bryan-hunter, @ThomasAribart:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Mar 6, 2021
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @G-Rath.

(Ping @hassankhan, @JonathanWilbur, @a-pavlenko, @fredericbarthelet, @bryan-hunter, @ThomasAribart.)

@elibarzilay elibarzilay merged commit 44ba0c4 into DefinitelyTyped:master Mar 7, 2021
@typescript-bot typescript-bot removed this from Needs Maintainer Action in New Pull Request Status Board Mar 7, 2021
@typescript-bot
Copy link
Contributor

I just published @types/serverless@1.78.21 to npm.

@G-Rath G-Rath deleted the serverless-update-types branch March 7, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants