Use NoticeMessage type for pg.Client 'notice' event.

[groner]

This PR updates the pg.Client 'notice' event to use uses the NoticeMessage type from pg-protocol.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/brianc/node-postgres/blob/25f658f227a1bcbe759423678a7ab4ba8e067994/packages/pg-protocol/src/messages.ts#L203-L222
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

This type first appears in pg-protocol 1.2.0, which was released with pg 8.0.1. I don't think the additional pg-protocol dependency will cause any conflicts because previous releases used a different name (pg-packet-stream).

[typescript-bot]

@groner Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• pg on npm, on unpkg
  • owner-approval: @HoldYourWaffle

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 51183,
  "author": "groner",
  "headCommitOid": "8503fc50cc2863d15214056b4119fa2461327bc1",
  "lastPushDate": "2021-02-11T18:07:09.000Z",
  "lastActivityDate": "2021-02-15T18:36:55.000Z",
  "maintainerBlessed": false,
  "mergeOfferDate": "2021-02-14T01:02:10.000Z",
  "mergeRequestDate": "2021-02-15T18:36:55.000Z",
  "mergeRequestUser": "groner",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "pg",
      "kind": "edit",
      "files": [
        {
          "path": "types/pg/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/pg/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/pg/pg-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "pspeter3",
        "HoldYourWaffle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "HoldYourWaffle",
      "date": "2021-02-14T01:01:33.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @pspeter3 @HoldYourWaffle — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@groner The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#51183	diff
Batch compilation
Memory usage (MiB)	71.3	72.1	+1.1%
Type count	10170	10283	+1%
Assignability cache size	1885	1898	+1%
Language service
Samples taken	514	525	+2%
Identifiers in tests	514	525	+2%
getCompletionsAtPosition
Mean duration (ms)	336.3	333.1	-0.9%
Mean CV	9.5%	9.6%
Worst duration (ms)	434.9	434.0	-0.2%
Worst identifier	connect	error
getQuickInfoAtPosition
Mean duration (ms)	341.8	341.4	-0.1%
Mean CV	8.8%	9.4%
Worst duration (ms)	422.9	407.8	-3.6%
Worst identifier	log	then

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[groner]

Ready to merge

[typescript-bot]

I just published @types/pg@7.14.10 to npm.

[ujwal-setlur]

This breaks typescript compilation when isolatedModules is set in tsconfig.json:

node_modules/pg-protocol/dist/messages.d.ts:86:21 - error TS2748: Cannot access ambient const enums when the '--isolatedModules' flag is provided.

86     readonly name = MessageName.copyData;
                       ~~~~~~~~~~~

node_modules/pg-protocol/dist/messages.d.ts:164:21 - error TS2748: Cannot access ambient const enums when the '--isolatedModules' flag is provided.

164     readonly name = MessageName.notice;

[ujwal-setlur]

brianc/node-postgres#2473

[groner]

@ujwal-setlur Apologies for breaking your build. This is my first time encountering this issue.

It would be nice if this can be fixed in pg-protocol, but if that can't happen in a timely manner then I suppose reverting this is the sensible thing to do.

[ujwal-setlur]

Thanks @groner. Let’s give it a couple or days before reverting. For now, I have disabled isolatedModules, but I would like to re-enable it.

[ujwal-setlur]

@groner, It looks like the upstream will not fix this. Can you please roll this back? Thanks.