Flip unstable_useTransition array params + edit eslint test

[damikun]

• This is breaking change in API from FB Core team from March.. Flip tuple order of useTransition facebook/react#20976

To be able to use last experimental versions we need to update this types for experimental...

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

[typescript-bot]

@damikun Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• react — on npm, on unpkg
  • owner-approval: @eps1lon, @dimitropoulos

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 52996,
  "author": "damikun",
  "headCommitOid": "3140ce2ac12e8651cef3daf184bac773a9c03160",
  "lastPushDate": "2021-05-17T11:29:09.000Z",
  "lastActivityDate": "2021-05-18T16:04:12.000Z",
  "mergeRequestDate": "2021-05-18T16:04:12.000Z",
  "mergeRequestUser": "dimitropoulos",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/experimental.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/test/experimental.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "digiguru",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "eps1lon",
      "date": "2021-05-17T15:32:57.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "dimitropoulos",
      "date": "2021-05-17T12:07:23.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[damikun]

@Jessidhia or @johnnyreilly looks good and green to go ;)

[dimitropoulos]

Huh. Why do I feel like we already got a PR for this recently? Was this not the only react API to switch the order of the tuple in the last few weeks. Either way.. Thanks! :)

[damikun]

Huh. Why do I feel like we already got a PR for this recently? Was this not the only react API to switch the order of the tuple in the last few weeks. Either way.. Thanks! :)

Hi @dimitropoulos

It was but it is not merged + is outdated + test did not pass (was not adjusted) + there was already changes in that files from another pulls and that brunch is behind.. + its not my brunch and is not updated or fixed for more weeks... Author seems to not fix it...

So i make directly working pull include tests adjustment to have it in types... I Need it for production CI in my project so don't wanna wait another unknown time :)

BTW Thx for confirm

[damikun]

Can we merge this?

[dimitropoulos]

Ready to merge

[typescript-bot]

🛂 Hi @dimitropoulos,

I can't accept a merge request until the PR has a green CI and was appropriately reviewed. I will let you know once that happens.

Thanks, and happy typing!

[typescript-bot]

I just published @types/react@17.0.6 to npm.