disableWallets not declared

[eliasfernandez]

As said on the manual (https://stripe.com/docs/js/payment_request/create#stripe_payment_request-options-disableWallets) StripePaymentRequest must have a disableWallets property but it is not declared on StripePaymentRequestOptions object.

[typescript-bot]

@eliasfernandez Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• stripe-v3 — on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ❌ Continuous integration tests have failed
• 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 55103,
  "author": "eliasfernandez",
  "headCommitOid": "41cf65b92456bb4c7c130088fb3553a7c282d1c4",
  "lastPushDate": "2021-08-12T09:07:30.000Z",
  "lastActivityDate": "2021-08-12T09:50:50.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "stripe-v3",
      "kind": "edit",
      "files": [
        {
          "path": "types/stripe-v3/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ejsmith",
        "amritk",
        "adamcmiel",
        "jleider",
        "galuszkak",
        "slangeder",
        "marlosin",
        "ttmarek",
        "kimehrenpohl",
        "KrishnaPravin",
        "hirochachacha",
        "paustint",
        "ksol",
        "matsuby",
        "kaznovac",
        "hartleyrobertson"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "kaznovac",
      "date": "2021-08-12T09:50:50.000Z"
    }
  ],
  "mainBotCommentID": 897474508,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/41cf65b92456bb4c7c130088fb3553a7c282d1c4/checks?check_suite_id=3479201763"
}

[typescript-bot]

Hey @eliasfernandez,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

[typescript-bot]

🔔 @ejsmith @amritk @AdamCmiel @jleider @galuszkak @slangeder @marlosin @ttmarek @kimehrenpohl @KrishnaPravin @hirochachacha @paustint @ksol @matsuby @kaznovac @hartleyrobertson — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@eliasfernandez The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[kaznovac]

thanks for the contribution @eliasfernandez .

can you please update the field type accordingly to the documentation?
https://stripe.com/docs/js/payment_request/create#stripe_payment_request-options-disableWallets

also if you have time please update the usage in the test class.

[kaznovac]

failing test is related to this change because of stricter undefined checks coming in the ts 4.4 microsoft/TypeScript#13195 - i.e. the new field should be marked as optional explicitly for backward compatibility

[kaznovac]

changes required, see comments https://github.com/DefinitelyTyped/DefinitelyTyped/pull/55103/files#r687559270

[typescript-bot]

@eliasfernandez One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

@eliasfernandez I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Sep 11th (in a week) if the issues aren't addressed.

[typescript-bot]

@eliasfernandez To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!