Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disableWallets not declared #55103

Closed
wants to merge 1 commit into from
Closed

disableWallets not declared #55103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions types/stripe-v3/index.d.ts
View file
Open in desktop
Expand Up @@ -856,6 +856,7 @@ declare namespace stripe {
requestPayerEmail?: boolean | undefined;
requestPayerPhone?: boolean | undefined;
requestShipping?: boolean | undefined;
disableWallets: any[] | undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @eliasfernandez .

can you please update the field type accordingly to the documentation?
https://stripe.com/docs/js/payment_request/create#stripe_payment_request-options-disableWallets

also if you have time please update the usage in the test class.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing test is related to this change because of stricter undefined checks coming in the ts 4.4 microsoft/TypeScript#13195 - i.e. the new field should be marked as optional explicitly for backward compatibility

}

interface UpdateDetails {
Expand Down