Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use jest-matcher-utils in @types/jest #58784

Merged
merged 2 commits into from Feb 23, 2022

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Feb 14, 2022

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

In an ongoing quest to make #44365 mergable, let's try to load more types from Jest itself. This time this.utils inside custom matchers.

I was unable to test this, just getting Error: ENOENT: no such file or directory, open '../notNeededPackages.json' when attempting to run npm install && npm test jest 🤷

EDIT: npm run test-all works

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 14, 2022

@SimenB Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58784,
  "author": "SimenB",
  "headCommitOid": "03831ee68b3f9f6a8d351b2e609c2a63a771a5d5",
  "mergeBaseOid": "64651581376f3b498f7d616863cfc626c8fbb11a",
  "lastPushDate": "2022-02-14T23:06:21.000Z",
  "lastActivityDate": "2022-02-23T07:03:55.000Z",
  "mergeOfferDate": "2022-02-23T00:21:14.000Z",
  "mergeRequestDate": "2022-02-23T07:03:55.000Z",
  "mergeRequestUser": "SimenB",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "jest",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/jest/jest-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/jest/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "NoHomey",
        "jwbay",
        "asvetliakov",
        "alexjoverm",
        "epicallan",
        "ikatyang",
        "wsmd",
        "JamieMason",
        "douglasduteil",
        "ahnpnl",
        "UselessPickles",
        "r3nya",
        "hotell",
        "sebald",
        "andys8",
        "antoinebrault",
        "gstamac",
        "ExE-Boss",
        "quassnoi",
        "Belco90",
        "tonyhallett",
        "ycmjason",
        "devanshj",
        "pawfa",
        "regevbr",
        "gerkindev",
        "domdomegg"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2022-02-23T00:20:35.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1039467543,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels Feb 14, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Feb 14, 2022
@typescript-bot
Copy link
Contributor

🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr @GerkinDev @domdomegg — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Feb 14, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Feb 14, 2022
@typescript-bot
Copy link
Contributor

@SimenB The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@SimenB
Copy link
Contributor Author

SimenB commented Feb 14, 2022

CI failure: microsoft/DefinitelyTyped-tools#399

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Feb 14, 2022
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Feb 14, 2022
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Feb 14, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Feb 14, 2022
@typescript-bot
Copy link
Contributor

@SimenB The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed The CI failed When GH Actions fails Untested Change This PR does not touch tests labels Feb 14, 2022
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Feb 14, 2022
@@ -858,7 +858,7 @@ expect.extend({

const receivedPrinted: string = this.utils.printReceived({});

const printedWithType: string = this.utils.printWithType('name', {}, (value: {}) => '');
const printedWithType: string = this.utils.printWithType('name', {}, (value) => '');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type in jest is unknown, not any

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in jestjs/jest#12405, but I think this change is fine anyways

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Feb 14, 2022
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 23, 2022
@typescript-bot
Copy link
Contributor

@SimenB: Everything looks good here. I am ready to merge this PR (at 03831ee) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@NoHomey, @jwbay, @asvetliakov, @alexjoverm, @epicallan, @ikatyang, @wsmd, @JamieMason, @douglasduteil, @ahnpnl, @UselessPickles, @r3nya, @Hotell, @sebald, @andys8, @antoinebrault, @gstamac, @ExE-Boss, @quassnoi, @Belco90, @tonyhallett, @ycmjason, @devanshj, @pawfa, @regevbr, @GerkinDev, @domdomegg: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Feb 23, 2022
@SimenB
Copy link
Contributor Author

SimenB commented Feb 23, 2022

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Feb 23, 2022
@typescript-bot typescript-bot merged commit cccb632 into DefinitelyTyped:master Feb 23, 2022
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 23, 2022
@SimenB SimenB deleted the jest-matcher-utils branch February 23, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants