New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use jest-matcher-utils
in @types/jest
#58784
chore: use jest-matcher-utils
in @types/jest
#58784
Conversation
@SimenB Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 58784,
"author": "SimenB",
"headCommitOid": "03831ee68b3f9f6a8d351b2e609c2a63a771a5d5",
"mergeBaseOid": "64651581376f3b498f7d616863cfc626c8fbb11a",
"lastPushDate": "2022-02-14T23:06:21.000Z",
"lastActivityDate": "2022-02-23T07:03:55.000Z",
"mergeOfferDate": "2022-02-23T00:21:14.000Z",
"mergeRequestDate": "2022-02-23T07:03:55.000Z",
"mergeRequestUser": "SimenB",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "jest",
"kind": "edit",
"files": [
{
"path": "types/jest/index.d.ts",
"kind": "definition"
},
{
"path": "types/jest/jest-tests.ts",
"kind": "test"
},
{
"path": "types/jest/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"NoHomey",
"jwbay",
"asvetliakov",
"alexjoverm",
"epicallan",
"ikatyang",
"wsmd",
"JamieMason",
"douglasduteil",
"ahnpnl",
"UselessPickles",
"r3nya",
"hotell",
"sebald",
"andys8",
"antoinebrault",
"gstamac",
"ExE-Boss",
"quassnoi",
"Belco90",
"tonyhallett",
"ycmjason",
"devanshj",
"pawfa",
"regevbr",
"gerkindev",
"domdomegg"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2022-02-23T00:20:35.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1039467543,
"ciResult": "pass"
} |
🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr @GerkinDev @domdomegg — please review this PR in the next few days. Be sure to explicitly select |
@SimenB The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
CI failure: microsoft/DefinitelyTyped-tools#399 |
a8371c5
to
f2bdf0e
Compare
@SimenB The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@@ -858,7 +858,7 @@ expect.extend({ | |||
|
|||
const receivedPrinted: string = this.utils.printReceived({}); | |||
|
|||
const printedWithType: string = this.utils.printWithType('name', {}, (value: {}) => ''); | |||
const printedWithType: string = this.utils.printWithType('name', {}, (value) => ''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type in jest is unknown
, not any
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in jestjs/jest#12405, but I think this change is fine anyways
@SimenB: Everything looks good here. I am ready to merge this PR (at 03831ee) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@NoHomey, @jwbay, @asvetliakov, @alexjoverm, @epicallan, @ikatyang, @wsmd, @JamieMason, @douglasduteil, @ahnpnl, @UselessPickles, @r3nya, @Hotell, @sebald, @andys8, @antoinebrault, @gstamac, @ExE-Boss, @quassnoi, @Belco90, @tonyhallett, @ycmjason, @devanshj, @pawfa, @regevbr, @GerkinDev, @domdomegg: you can do this too.) |
Ready to merge |
Please fill in this template.
npm test <package to test>
.If changing an existing definition:
In an ongoing quest to make #44365 mergable, let's try to load more types from Jest itself. This time
this.utils
inside custom matchers.I was unable to test this, just getting
Error: ENOENT: no such file or directory, open '../notNeededPackages.json'
when attempting to runnpm install && npm test jest
🤷EDIT:
npm run test-all
works