[node] Improving X509Certificate typings

[connorjburton]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: Official Node Documentation
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

---

Hi, this is my first time contributing so please let me know of any mistakes, I wasn't sure on the different v folders and how that all behaves.

Here is a breakdown of the changes, you can generate certificates yourself here to test with.

• fingerprint512 - This is a missing type, introduced in v16.14.0
• subjectAltName - This can be undefined
• infoAccess - This can be undefined
• checkEmail - This does not accept all X509 options other than subject
• checkIp - Since v16.14.1 no longer accepts options. Is this a breaking change?

[typescript-bot]

@connorjburton Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• node — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 59653,
  "author": "connorjburton",
  "headCommitOid": "804437c204a2c6dcd225abd1074aab420910724a",
  "mergeBaseOid": "0afa1ae91d2c602d83f01016d10359cf8c2d7971",
  "lastPushDate": "2022-04-28T19:57:35.000Z",
  "lastActivityDate": "2022-04-28T19:57:35.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/crypto.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v16/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/test/crypto.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "chefgsaroar",
      "date": "2022-04-28T03:33:51.000Z",
      "abbrOid": "50e3ae8"
    },
    {
      "type": "stale",
      "reviewer": "peterblazejewicz",
      "date": "2022-04-04T21:38:37.000Z",
      "abbrOid": "50e3ae8"
    }
  ],
  "mainBotCommentID": 1086316050,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[connorjburton]

I saw some errors in the logs for @types/mongodb but that doesn't exist anymore in DefinitelyTyped? I can also see other PRs with Node have the same errors such as this and this.

Something is broken in the tests in general?

[typescript-bot]

@connorjburton The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[josh-]

I saw some errors in the logs for @types/mongodb but that doesn't exist anymore in DefinitelyTyped? I can also see other PRs with Node have the same errors such as this and this.

Something is broken in the tests in general?

Yeah a maintainer let me know in another PR that there are currently some ongoing issues: #59434 (comment)

[connorjburton]

@josh- Thank you, I will sit tight.

[peterblazejewicz]

can all the changes be added in v16 as well? thx!

[connorjburton]

Thanks for the review @peterblazejewicz - I have updated the PR to apply the changes in the v16 folder too.

[typescript-bot]

@connorjburton The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@connorjburton The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[peterblazejewicz]

LGTM!
@connorjburton thx!

[typescript-bot]

@connorjburton I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on May 4th (in a week) if the issues aren't addressed.

[connorjburton]

Hey @peterblazejewicz - I saw you rebased #59761 to fix the CI problem. I tried to do this but it says it's all up to date, maybe because I am using sparse-checkout? Would you be able to rebase this PR to resolve the CI problems please? Thanks

[peterblazejewicz]

@connorjburton done, it would take circa half an hour for tests to fully finish the run

[typescript-bot]

@chefgsaroar, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?