fix(node): add ocb modes to crypto, fix ccm and gcm iv

[panva]

AES OCB modes were added in v10.10.0. This adds the respective type definitions for OCB ciphers in crypto.createCipheriv and crypto.createDecipheriv.

Also fixes the iv being mandatory (not null) for the GCM and CCM overloads.

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: crypto: add support for OCB mode for AEAD nodejs/node#21447

IV required for the CCM and GCM overloads

> 'ivLength' in crypto.getCipherInfo('aes-128-ccm')
true
> 'ivLength' in crypto.getCipherInfo('aes-128-gcm')
true
> 'ivLength' in crypto.getCipherInfo('aes-128-ocb')
true

[typescript-bot]

@panva Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• node — on npm, on unpkg
  • owner-approval: @peterblazejewicz

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 59761,
  "author": "panva",
  "headCommitOid": "29d8c4a1cf82b9058f82560ca0831b08ae32075f",
  "mergeBaseOid": "2dd25a142c4464f1cf5f0659e2779203cde454ad",
  "lastPushDate": "2022-04-24T15:15:41.000Z",
  "lastActivityDate": "2022-04-24T20:40:27.000Z",
  "mergeOfferDate": "2022-04-24T20:15:06.000Z",
  "mergeRequestDate": "2022-04-24T20:40:27.000Z",
  "mergeRequestUser": "panva",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/crypto.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v12/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v12/test/crypto.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v14/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v14/test/crypto.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v16/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/test/crypto.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-04-24T20:14:27.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "SimonSchick",
      "date": "2022-04-14T13:52:20.000Z",
      "abbrOid": "e133784"
    }
  ],
  "mainBotCommentID": 1092619585,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@panva The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@panva The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[panva]

CI failures are unrelated.

[panva]

When unrelated CI failures grind the very core module type definitions progress to a halt...

#59653
#59828
#59786
#59587

[typescript-bot]

@panva The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[SimonSchick]

This looks fine, we can probably skip with CI failures after maintainer review.

[panva]

Merge? Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request.

Let's get this in before work on v18 starts.

[peterblazejewicz]

FYI: I've updated from master giving it fixes to types to pass CI

[typescript-bot]

@peterblazejewicz, @SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[typescript-bot]

@panva: Everything looks good here. I am ready to merge this PR (at 29d8c4a) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13: you can do this too.)

[typescript-bot]

@SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[panva]

Ready to merge