Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] Move experimental APIs to stable for React 18 #61649

Closed

Conversation

steinybot
Copy link

@steinybot steinybot commented Aug 10, 2022

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Update entry point exports facebook/react#21488
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 10, 2022

@steinybot Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 61649,
  "author": "steinybot",
  "headCommitOid": "8a92a6243ade3790970fe218b06e9d1a4069a130",
  "mergeBaseOid": "60f97fb97c2f0ad032547ff63e8486b89b40a12c",
  "lastPushDate": "2022-08-10T20:20:55.000Z",
  "lastActivityDate": "2022-08-10T21:13:04.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/experimental.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/test/experimental.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/test/tsx.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan",
        "priyanshurav"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "eps1lon",
      "date": "2022-08-10T21:13:04.000Z"
    }
  ],
  "mainBotCommentID": 1211228023,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/8a92a6243ade3790970fe218b06e9d1a4069a130/checks?check_suite_id=7759619135"
}

@typescript-bot
Copy link
Contributor

@steinybot steinybot closed this Aug 10, 2022
@typescript-bot typescript-bot removed this from Waiting for Code Reviews in New Pull Request Status Board Aug 10, 2022
@steinybot steinybot reopened this Aug 10, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Aug 10, 2022
@steinybot steinybot changed the title Move experimental APIs to stable for React 18 [react] Move experimental APIs to stable for React 18 Aug 10, 2022
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Aug 10, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Aug 10, 2022
@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 10, 2022

@steinybot The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SuspenseList is not part of react@^18.0.0 but react@experimental. While the PR made that change, SuspenseList was later removed from the stable entrypoint

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Aug 10, 2022
@typescript-bot
Copy link
Contributor

@steinybot One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@steinybot
Copy link
Author

@eps1lon It seems you are right: https://codesandbox.io/s/react-suspense-list-d993mu?file=/src/App.tsx

The comment at the top of experimental.d.ts says:

// See https://github.com/facebook/react/blob/master/packages/react/src/React.js to see how the exports are declared,
// and https://github.com/facebook/react/blob/master/packages/shared/ReactFeatureFlags.js to verify which APIs are
// flagged experimental or not. Experimental APIs will be tagged with `__EXPERIMENTAL__`.

That comment really should say to look in https://github.com/facebook/react/blob/main/packages/react/index.stable.js. I've been searching for ages trying to work it out and only now spotted that there is a different file.

@steinybot steinybot closed this Aug 10, 2022
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board Aug 10, 2022
@eps1lon
Copy link
Collaborator

eps1lon commented Aug 10, 2022

Documentation and https://unpkg.com/react et al. are usually best to identify what ends up being available.

@Jessidhia
Copy link
Member

That comment really should say to look in https://github.com/facebook/react/blob/main/packages/react/index.stable.js.

This was likely a refactoring done in the React side after that comment was written 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Revision needed This PR needs code changes before it can be merged. The CI failed When GH Actions fails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants