pg: remove not supposed option from ClientConfig

[kz-d]

parseInputDatesAsUTC does not work as an option for ClientConfig in any node-postgres version.

・I searched the source code, but there is no place where parseInputDatesAsUTC is overridden with the given arguments.
https://github.com/brianc/node-postgres
・There is no mention of this in the official documentation.
https://node-postgres.com/apis/client#new-client
・when I try to execute the following source code, parseInputDatesAsUTC is processed as false.

const client = new Client({
  host: 'localhost',
  port: 5332,
  user: 'database-user',
  password: 'password!!',
  parseInputDatesAsUTC: true,
})

I think it was added due to some misunderstand.

related: brianc/node-postgres#1350

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

[typescript-bot]

@kz-d Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• pg — on npm, on unpkg
  • owner-approval: @HoldYourWaffle

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 63690,
  "author": "kz-d",
  "headCommitOid": "34c249facc2de000285dbbe98b80d808712460bc",
  "mergeBaseOid": "ee2690789110ba2c962f1f489d1ee07278ac63d3",
  "lastPushDate": "2022-12-21T14:06:16.000Z",
  "lastActivityDate": "2022-12-23T01:12:18.000Z",
  "mergeOfferDate": "2022-12-22T19:19:12.000Z",
  "mergeRequestDate": "2022-12-23T01:12:18.000Z",
  "mergeRequestUser": "kz-d",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "pg",
      "kind": "edit",
      "files": [
        {
          "path": "types/pg/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pspeter3",
        "HoldYourWaffle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-12-22T19:18:27.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "HoldYourWaffle",
      "date": "2022-12-22T07:41:51.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1361385952,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @pspeter3 @HoldYourWaffle — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[HoldYourWaffle]

Oh wow this is a strange one.

Seems like it was approved by both me and @peterblazejewicz in #42849 based on defaults.js. In our defense, it's a little strange to have a non-overridable "default option"...
Related: brianc/node-postgres#2141

This option was never added to the tests (booo), so it makes sense that the tests haven't been changed.

[peterblazejewicz]

@kz-d thanks!

[kz-d]

thanks for review!

[kz-d]

Ready to merge

[stuft2]

I'm pretty sure you can override this variable like pg.defaults.parseInputDatesAsUTC = true. It should have been added to the Defaults interface and not the Client constructor options.