Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vuelidate] Fix max call stack size error in Vue 2.7.6-14 #64311

Merged
merged 4 commits into from Feb 13, 2023

Conversation

IGx89
Copy link
Contributor

@IGx89 IGx89 commented Feb 10, 2023

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 10, 2023

@IGx89 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 64311,
  "author": "IGx89",
  "headCommitOid": "be237d6a2e9b880311100c1993ae20be45ece054",
  "mergeBaseOid": "a7732c024ce77bcee36cea88228cf4bb210f5da7",
  "lastPushDate": "2023-02-13T15:37:04.000Z",
  "lastActivityDate": "2023-02-13T23:13:32.000Z",
  "mergeOfferDate": "2023-02-13T22:47:20.000Z",
  "mergeRequestDate": "2023-02-13T23:13:32.000Z",
  "mergeRequestUser": "IGx89",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "vuelidate",
      "kind": "edit",
      "files": [
        {
          "path": "types/vuelidate/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/vuelidate/vue.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/vuelidate/vuelidate-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "janesser",
        "jubairsaidi",
        "orblazer",
        "shadrus"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "janesser",
      "date": "2023-02-13T22:46:35.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1426420700,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Feb 10, 2023
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Feb 10, 2023
@typescript-bot
Copy link
Contributor

🔔 @janesser @jubairsaidi @orblazer @shadrus — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Feb 10, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Feb 10, 2023
@typescript-bot
Copy link
Contributor

@IGx89 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@IGx89
Copy link
Contributor Author

IGx89 commented Feb 10, 2023

This is an existing failure unrelated to my changes, and in a dependency (Vue) and not this package's types. Appears that Vue's types may use features not present in TypeScript 4.2.

@IGx89
Copy link
Contributor Author

IGx89 commented Feb 10, 2023

Confirmed, Vue's types only support TypeScript 4.4+: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-4.html#symbol-and-template-string-pattern-index-signatures. How can I tell the tests that...

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Feb 10, 2023
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Feb 10, 2023
@DangerBotOSS
Copy link

DangerBotOSS commented Feb 10, 2023

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

vuelidate (unpkg)

was missing the following properties:

  1. Vuelidate
  2. withParams

Generated by 🚫 dangerJS against be237d6

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Feb 10, 2023
Copy link
Contributor

@janesser janesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one ought think of the test file.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Feb 11, 2023
@typescript-bot typescript-bot removed Popular package This PR affects a popular package (as counted by NPM download counts). Owner Approved A listed owner of this package signed off on the pull request. Untested Change This PR does not touch tests labels Feb 13, 2023
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Feb 13, 2023
@typescript-bot
Copy link
Contributor

@janesser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Copy link
Contributor

@janesser janesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 13, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Feb 13, 2023
@typescript-bot
Copy link
Contributor

@IGx89: Everything looks good here. I am ready to merge this PR (at be237d6) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@janesser, @jubairsaidi, @orblazer, @shadrus: you can do this too.)

@IGx89
Copy link
Contributor Author

IGx89 commented Feb 13, 2023

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Feb 13, 2023
@typescript-bot typescript-bot merged commit b09276c into DefinitelyTyped:master Feb 13, 2023
@IGx89 IGx89 deleted the fix-vuelidate-vue-2.7 branch February 13, 2023 23:14
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants