New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vuelidate] Fix max call stack size error in Vue 2.7.6-14 #64311
[vuelidate] Fix max call stack size error in Vue 2.7.6-14 #64311
Conversation
@IGx89 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 64311,
"author": "IGx89",
"headCommitOid": "be237d6a2e9b880311100c1993ae20be45ece054",
"mergeBaseOid": "a7732c024ce77bcee36cea88228cf4bb210f5da7",
"lastPushDate": "2023-02-13T15:37:04.000Z",
"lastActivityDate": "2023-02-13T23:13:32.000Z",
"mergeOfferDate": "2023-02-13T22:47:20.000Z",
"mergeRequestDate": "2023-02-13T23:13:32.000Z",
"mergeRequestUser": "IGx89",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "vuelidate",
"kind": "edit",
"files": [
{
"path": "types/vuelidate/index.d.ts",
"kind": "definition"
},
{
"path": "types/vuelidate/vue.d.ts",
"kind": "definition"
},
{
"path": "types/vuelidate/vuelidate-tests.ts",
"kind": "test"
}
],
"owners": [
"janesser",
"jubairsaidi",
"orblazer",
"shadrus"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "janesser",
"date": "2023-02-13T22:46:35.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1426420700,
"ciResult": "pass"
} |
🔔 @janesser @jubairsaidi @orblazer @shadrus — please review this PR in the next few days. Be sure to explicitly select |
@IGx89 The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
This is an existing failure unrelated to my changes, and in a dependency (Vue) and not this package's types. Appears that Vue's types may use features not present in TypeScript 4.2. |
Confirmed, Vue's types only support TypeScript 4.4+: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-4.html#symbol-and-template-string-pattern-index-signatures. How can I tell the tests that... |
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. vuelidate (unpkg)was missing the following properties:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, one ought think of the test file.
@janesser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
@IGx89: Everything looks good here. I am ready to merge this PR (at be237d6) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@janesser, @jubairsaidi, @orblazer, @shadrus: you can do this too.) |
Ready to merge |
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition: