Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pnpm install script for large PRs #67460

Merged

Conversation

jakebailey
Copy link
Member

This should unblock PRs like #67455 which touch many packages.

pnpm builds a massive string at some point (pnpm/pnpm#5056 or pnpm/pnpm#7079). The easiest workaround is to detect when the hack this script does fails, and just give up and resort to a full install.

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 20, 2023

@jakebailey Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 67460,
  "author": "jakebailey",
  "headCommitOid": "18c38773e683d2e729102e64c6662490742e2711",
  "mergeBaseOid": "952921af31f19e0a78161d3b0a2b856bdf6a400d",
  "lastPushDate": "2023-11-20T22:22:08.000Z",
  "lastActivityDate": "2023-11-20T22:31:13.000Z",
  "mergeOfferDate": "2023-11-20T22:29:59.000Z",
  "mergeRequestDate": "2023-11-20T22:31:13.000Z",
  "mergeRequestUser": "jakebailey",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": ".github/workflows/CI.yml",
          "kind": "infrastructure"
        },
        {
          "path": "azure-pipelines.yml",
          "kind": "infrastructure"
        },
        {
          "path": "scripts/pnpm-install.sh",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2023-11-20T22:28:03.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1819900457,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @jakebailey — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Nov 20, 2023
@@ -44,6 +44,8 @@ jobs:
- run: ./scripts/pnpm-install.sh
name: pnpm install

- run: pnpm ls
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I'm here...

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in New Pull Request Status Board Nov 20, 2023
@typescript-bot typescript-bot added the Self Merge This PR can now be self-merged by the PR author or an owner label Nov 20, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Nov 20, 2023
@typescript-bot
Copy link
Contributor

@jakebailey: Everything looks good here. I am ready to merge this PR (at 18c3877) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@jakebailey
Copy link
Member Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Nov 20, 2023
@typescript-bot typescript-bot merged commit 4a27acc into DefinitelyTyped:master Nov 20, 2023
3 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Nov 21, 2023
@jakebailey jakebailey deleted the fix-pnpm-install-script branch March 7, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants