Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxTimeMS propagation tests run #3939

Closed
wants to merge 3 commits into from

Conversation

noisersup
Copy link
Member

Description

Closes #2983.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38fb5e4) 74.06% compared to head (733a391) 74.02%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3939      +/-   ##
==========================================
- Coverage   74.06%   74.02%   -0.05%     
==========================================
  Files         330      330              
  Lines       25944    25944              
==========================================
- Hits        19215    19204      -11     
- Misses       5589     5597       +8     
- Partials     1140     1143       +3     

see 4 files with indirect coverage changes

Flag Coverage Δ
filter-true 70.65% <ø> (-0.05%) ⬇️
hana-1 ?
integration 70.65% <ø> (-0.05%) ⬇️
mongodb-1 5.18% <ø> (+0.01%) ⬆️
postgresql-1 49.51% <ø> (-0.11%) ⬇️
postgresql-2 52.16% <ø> (-0.03%) ⬇️
postgresql-3 50.89% <ø> (-0.02%) ⬇️
sqlite-1 48.79% <ø> (ø)
sqlite-2 51.24% <ø> (-0.04%) ⬇️
sqlite-3 49.99% <ø> (-0.10%) ⬇️
unit 30.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup changed the title Propagate maxTimeMS of find and aggregate to getMore maxTimeMS propagation tests run Jan 5, 2024
@noisersup noisersup closed this Jan 9, 2024
@noisersup noisersup mentioned this pull request Jan 9, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Propagate maxTimeMS of find and aggregate to getMore
1 participant