Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup TODO for speculative authenticate #4143

Merged
merged 4 commits into from Mar 6, 2024

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Mar 5, 2024

Description

Both TODO does not seem to be related to speculative authenticate 🤔, so I created issues for them. Let me know if I'm wrong.

One is about supporting filter in usersInfo command #4141, another is creating user for $external database #4142.

Closes #3777.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Mar 5, 2024
@chilagrow chilagrow added this to the Next milestone Mar 5, 2024
@chilagrow chilagrow self-assigned this Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.92%. Comparing base (25e6b46) to head (c358160).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4143      +/-   ##
==========================================
- Coverage   74.89%   73.92%   -0.98%     
==========================================
  Files         353      353              
  Lines       22680    22680              
==========================================
- Hits        16987    16767     -220     
- Misses       4413     4638     +225     
+ Partials     1280     1275       -5     
Files Coverage Δ
internal/handler/msg_createuser.go 75.52% <ø> (ø)
internal/handler/msg_usersinfo.go 76.72% <ø> (ø)

... and 30 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.24% <ø> (-1.39%) ⬇️
hana-1 ?
integration 67.24% <ø> (-1.46%) ⬇️
mongodb-1 4.75% <ø> (ø)
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 48.27% <ø> (-0.10%) ⬇️
postgresql-2 ?
postgresql-3 49.22% <ø> (-0.10%) ⬇️
sqlite-1 47.49% <ø> (-0.10%) ⬇️
sqlite-2 47.91% <ø> (-0.05%) ⬇️
sqlite-3 48.26% <ø> (-0.15%) ⬇️
unit 32.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow requested review from a team, henvic, rumyantseva and noisersup March 5, 2024 06:05
@chilagrow chilagrow changed the title Cleanup speculative authenticate Cleanup TODO for speculative authenticate Mar 5, 2024
@chilagrow chilagrow marked this pull request as ready for review March 5, 2024 06:06
@chilagrow chilagrow requested a review from a team as a code owner March 5, 2024 06:06
@chilagrow chilagrow requested a review from AlekSi March 5, 2024 06:06
@chilagrow chilagrow enabled auto-merge (squash) March 5, 2024 06:06
henvic
henvic previously approved these changes Mar 5, 2024
@chilagrow chilagrow merged commit 4a67734 into FerretDB:main Mar 6, 2024
35 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support speculativeAuthenticate
4 participants