Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup TODO for speculative authenticate #4143

Merged
merged 4 commits into from Mar 6, 2024
Merged

Cleanup TODO for speculative authenticate #4143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c700100
update issue for todo
chilagrow Mar 5, 2024
333216e
update user doc too
chilagrow Mar 5, 2024
88b12e2
remove todo
chilagrow Mar 5, 2024
c358160
Merge branch 'main' into cleanup-speculative-auth
mergify[bot] Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions internal/handler/msg_createuser.go
View file
Open in desktop
Expand Up @@ -46,8 +46,6 @@ func (h *Handler) MsgCreateUser(ctx context.Context, msg *wire.OpMsg) (*wire.OpM
return nil, err
}

// TODO https://github.com/FerretDB/FerretDB/issues/3777
// TODO https://github.com/FerretDB/FerretDB/issues/3778
if dbName != "$external" && !document.Has("pwd") {
return nil, handlererrors.NewCommandErrorMsg(
handlererrors.ErrBadValue,
Expand Down
2 changes: 1 addition & 1 deletion internal/handler/msg_usersinfo.go
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ func (h *Handler) MsgUsersInfo(ctx context.Context, msg *wire.OpMsg) (*wire.OpMs
return nil, lazyerrors.Error(err)
}

// TODO https://github.com/FerretDB/FerretDB/issues/3777
// TODO https://github.com/FerretDB/FerretDB/issues/4141
if err = common.UnimplementedNonDefault(document, "filter", func(v any) bool {
if v == nil || v == types.Null {
return true
Expand Down
2 changes: 1 addition & 1 deletion website/docs/reference/supported-commands.md
View file
Open in desktop
Expand Up @@ -209,7 +209,7 @@ Related [issue](https://github.com/FerretDB/FerretDB/issues/78).
| | `showCustomData` | 鈿狅笍 | |
| | `showPrivileges` | 鈿狅笍 | |
| | `showAuthenticationRestrictions` | 鈿狅笍 | |
| | `filter` | 鈿狅笍 | |
| | `filter` | 鈿狅笍 | [Issue](https://github.com/FerretDB/FerretDB/issues/4141) |
| | `comment` | 鈿狅笍 | |

### Authentication Commands
Expand Down