Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper for checking local peers #4159

Closed
wants to merge 1 commit into from
Closed

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 7, 2024

Description

Plus some small fixes.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Mar 7, 2024
@AlekSi AlekSi added this to the Next milestone Mar 7, 2024
@AlekSi AlekSi self-assigned this Mar 7, 2024
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners March 7, 2024 06:27
@AlekSi AlekSi enabled auto-merge (squash) March 7, 2024 06:27
@AlekSi AlekSi requested review from a team, henvic and noisersup March 7, 2024 06:27
@AlekSi AlekSi assigned chilagrow and unassigned AlekSi Mar 7, 2024
Comment on lines +100 to +101
connInfo.rw.Lock()
defer connInfo.rw.Unlock()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.78%. Comparing base (892780a) to head (ec0bc37).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4159      +/-   ##
==========================================
- Coverage   74.31%   73.78%   -0.53%     
==========================================
  Files         353      353              
  Lines       22789    22793       +4     
==========================================
- Hits        16935    16818     -117     
- Misses       4556     4694     +138     
+ Partials     1298     1281      -17     
Files Coverage Δ
ferretdb/ferretdb.go 86.51% <ø> (ø)
integration/setup/setup.go 81.25% <ø> (ø)
internal/clientconn/conninfo/conn_info.go 96.55% <100.00%> (+0.12%) ⬆️
internal/handler/msg_whatsmyuri.go 100.00% <100.00%> (ø)
internal/clientconn/conn.go 51.35% <33.33%> (-0.35%) ⬇️

... and 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.21% <50.00%> (-0.63%) ⬇️
hana-1 ?
integration 67.21% <50.00%> (-0.63%) ⬇️
mongodb-1 4.87% <0.00%> (-0.01%) ⬇️
postgresql-1 48.45% <25.00%> (+0.02%) ⬆️
postgresql-2 51.26% <37.50%> (+4.07%) ⬆️
postgresql-3 49.47% <12.50%> (-0.01%) ⬇️
sqlite-1 47.53% <25.00%> (+0.02%) ⬆️
sqlite-2 ?
sqlite-3 48.58% <12.50%> (+0.01%) ⬆️
unit 32.49% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@chilagrow chilagrow mentioned this pull request Mar 7, 2024
9 tasks
@AlekSi AlekSi closed this Mar 7, 2024
auto-merge was automatically disabled March 7, 2024 08:02

Pull request was closed

@AlekSi AlekSi deleted the local branch March 7, 2024 08:02
@AlekSi AlekSi removed this from the Next milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants