Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PLAIN mechanism authentication incorrectly working #4163

Merged
merged 5 commits into from
Mar 11, 2024

use lock less

4748386
Select commit
Failed to load commit list.
Merged

Fix PLAIN mechanism authentication incorrectly working #4163

use lock less
4748386
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Mar 11, 2024 in 0s

73.80% (-0.94%) compared to e98d536

View this Pull Request on Codecov

73.80% (-0.94%) compared to e98d536

Details

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.80%. Comparing base (e98d536) to head (4748386).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4163      +/-   ##
==========================================
- Coverage   74.74%   73.80%   -0.94%     
==========================================
  Files         353      353              
  Lines       22789    22797       +8     
==========================================
- Hits        17034    16826     -208     
- Misses       4470     4692     +222     
+ Partials     1285     1279       -6     
Files Coverage Δ
internal/backends/mysql/metadata/registry.go 64.13% <100.00%> (-0.95%) ⬇️
internal/backends/postgresql/metadata/registry.go 71.89% <100.00%> (-0.41%) ⬇️
internal/clientconn/conninfo/conn_info.go 96.49% <100.00%> (+0.06%) ⬆️
internal/handler/msg_logout.go 100.00% <100.00%> (ø)
internal/handler/msg_saslstart.go 78.70% <100.00%> (+0.13%) ⬆️
internal/handler/authenticate.go 76.81% <86.66%> (-0.97%) ⬇️

... and 28 files with indirect coverage changes