Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/checkout from 4.0.0 to 4.1.0 #2700

Merged
merged 3 commits into from Sep 29, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 26, 2023

Bumps actions/checkout from 4.0.0 to 4.1.0.

Release notes

Sourced from actions/checkout's releases.

v4.1.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v4.0.0...v4.1.0

Changelog

Sourced from actions/checkout's changelog.

v4.1.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.0.0...v4.1.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Sep 26, 2023
Comment on lines +90 to 93
uses: actions/checkout@v4.1.0
with:
# fetch all history so that setuptools-scm works
fetch-depth: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try the treeless clone in actions/checkout@v4.1.0 to see if it speeds up git checkout (currently about 15s on Windows)? Xref actions/checkout#1396 and https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone.

Suggested change
uses: actions/checkout@v4.1.0
with:
# fetch all history so that setuptools-scm works
fetch-depth: 0
uses: actions/checkout@v4.1.0
with:
# fetch all history with treeless clone so that setuptools-scm works
filter: tree:0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems the pygmt version string is still incorrect.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah, it's only a few seconds faster too, so not really worth it perhaps. Ok to revert the change and merge.

seisman and others added 2 commits September 28, 2023 10:14
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
This reverts commit c8a3409.
@seisman seisman merged commit ad60331 into main Sep 29, 2023
12 of 13 checks passed
@seisman seisman deleted the dependabot/github_actions/actions/checkout-4.1.0 branch September 29, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants