Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump actions/checkout from 4.0.0 to 4.1.0 #2700

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Bump actions/checkout from 4.0.0 to 4.1.0 #2700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6071b80
Bump actions/checkout from 4.0.0 to 4.1.0
dependabot[bot] Sep 26, 2023
c8a3409
Try treeless clone
seisman Sep 28, 2023
2d4b755
Revert "Try treeless clone"
seisman Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cache_data.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
steps:
# Checkout current git repository
- name: Checkout
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0
with:
# fetch all history so that setuptools-scm works
fetch-depth: 0
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-links.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ jobs:

steps:
- name: Checkout the repository
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0
with:
path: repository

- name: Checkout the documentation
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0
with:
ref: gh-pages
path: documentation
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
steps:
# Checkout current git repository
- name: Checkout
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0
with:
# fetch all history so that setuptools-scm works
fetch-depth: 0
Expand Down Expand Up @@ -126,7 +126,7 @@ jobs:
run: make -C doc clean all

- name: Checkout the gh-pages branch
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0
with:
ref: gh-pages
# Checkout to this folder instead of the current one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_doctests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
steps:
# Checkout current git repository
- name: Checkout
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0
with:
# fetch all history so that setuptools-scm works
fetch-depth: 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
steps:
# Checkout current git repository
- name: Checkout
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0
with:
# fetch all history so that setuptools-scm works
fetch-depth: 0
Comment on lines +90 to 93
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try the treeless clone in actions/checkout@v4.1.0 to see if it speeds up git checkout (currently about 15s on Windows)? Xref actions/checkout#1396 and https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone.

Suggested change
uses: actions/checkout@v4.1.0
with:
# fetch all history so that setuptools-scm works
fetch-depth: 0
uses: actions/checkout@v4.1.0
with:
# fetch all history with treeless clone so that setuptools-scm works
filter: tree:0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems the pygmt version string is still incorrect.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah, it's only a few seconds faster too, so not really worth it perhaps. Ok to revert the change and merge.

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci_tests_dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
steps:
# Checkout current git repository
- name: Checkout
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0
if: github.event_name != 'repository_dispatch'
with:
# fetch all history so that setuptools-scm works
Expand All @@ -70,7 +70,7 @@ jobs:

# Checkout the pull request branch
- name: Checkout
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0
if: github.event_name == 'repository_dispatch'
with:
token: ${{ steps.generate-token.outputs.token }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_tests_legacy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
steps:
# Checkout current git repository
- name: Checkout
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0
with:
# fetch all history so that setuptools-scm works
fetch-depth: 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dvc-diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0
with:
# fetch all history so that dvc diff works
fetch-depth: 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/format-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
private_key: ${{ secrets.APP_PRIVATE_KEY }}

# Checkout the pull request branch
- uses: actions/checkout@v4.0.0
- uses: actions/checkout@v4.1.0
with:
token: ${{ steps.generate-token.outputs.token }}
repository: ${{ github.event.client_payload.pull_request.head.repo.full_name }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-to-pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0
with:
# fetch all history so that setuptools-scm works
fetch-depth: 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-baseline-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0

- name: Setup data version control (DVC)
uses: iterative/setup-dvc@v1.1.2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/style_checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
steps:
# Checkout current git repository
- name: Checkout
uses: actions/checkout@v4.0.0
uses: actions/checkout@v4.1.0

# Setup Python
- name: Set up Python
Expand Down