-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made google_document_ai_processor_default_version test ignore changes to version field #7317
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 20 insertions(+), 4 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccDocumentAIProcessorDefaultVersion_documentaiDefaultVersionExample|TestAccFirebaserulesRelease_BasicRelease |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… to version field (GoogleCloudPlatform#7317) * Fixed permadiff for channel-based processor versions * Removed update functionality and updated tests & docs to use ignore_changes * Tweaked docs example * Removed update settings
… to version field (GoogleCloudPlatform#7317) * Fixed permadiff for channel-based processor versions * Removed update functionality and updated tests & docs to use ignore_changes * Tweaked docs example * Removed update settings
Resolved hashicorp/terraform-provider-google#12905 by altering the test to ignore changes (and improving documentation.)
projectNumberDiffSuppress
is already in place to handle diffs based solely on the project id -> project number change; the larger issue is that the API replaces release channels (now called "stable" and "rc") with specific API versions. Unfortunately, this API does not supply a way to extract the list of versions in a particular release channel, so there's no way to make a data source to get the "latest stable version" and have the resource use that. Fully suppressing the diff in the provider would mislead users into thinking that they are on the latest stable or rc release, when in fact they might be extremely out of date.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)