feat(grpc-xds): Control plane mTLS for Go #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements mTLS for connections from xDS clients to the xDS control plane management server as per gRFC A65. gRPC-Java as of v1.61.0 does not yet support "tls" type channel credentials in the gRPC xDS bootstrap file, so control plane mTLS is disabled by default for the Java implementation here. On the control plane side, the feature is controlled by flags in the `xds_features.yaml` file. On the client side, there is a Kubernetes resource patch for the Java deployment that swaps `"type": "tls"` for `"type": "insecure"`.
halvards
added a commit
that referenced
this pull request
Feb 2, 2024
gRPC-Go as of [v1.61.0](https://github.com/grpc/grpc-go/releases/tag/v1.61.0) supports [gRFC A65: mTLS Credentials in xDS Bootstrap File](https://github.com/grpc/proposal/blob/8c31bfedded5f0a51c4933e9e9a8246122f9c41a/A65-xds-mtls-creds-in-bootstrap.md), see grpc/grpc-go#6757. These changes add control plane mTLS for the Go control plane and sample application implementations, controlled by flags in the `xds_features.yaml` configuration file.
halvards
added a commit
that referenced
this pull request
Feb 2, 2024
gRPC-Go as of [v1.61.0](https://github.com/grpc/grpc-go/releases/tag/v1.61.0) supports [gRFC A65: mTLS Credentials in xDS Bootstrap File](https://github.com/grpc/proposal/blob/8c31bfedded5f0a51c4933e9e9a8246122f9c41a/A65-xds-mtls-creds-in-bootstrap.md), see grpc/grpc-go#6757. These changes add control plane mTLS for the Go control plane and sample application implementations, controlled by flags in the `xds_features.yaml` configuration file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC-Go as of v1.61.0 supports gRFC A65: mTLS Credentials in xDS Bootstrap File, see grpc/grpc-go#6757.
These changes add control plane mTLS for the Go control plane and sample application implementations, controlled by flags in the
xds_features.yamlconfiguration file.