feat: Support Bazel platform mappings #9300
Conversation
|
Looking for some feedback on whether I should drop this change, continue with some modifications to the approach, or continue as-is. Let me know! Thanks. |
aran
force-pushed
the
bazel-platforms
branch
from
0137e1e
to
450c948
Compare
|
@renzodavid9 This is the PR we discussed in the Skaffold office hours call at end of Feb. Would be great to get your feedback if you have a chance. Thanks! |
|
Hey @aran, I'll get familiar with the Bazel platforms to understand more about how they work. Also I'll check if we need to do changes in other parts of Skaffold in order to fully support this. Thanks! |
aran
force-pushed
the
bazel-platforms
branch
2 times, most recently
from
c51fd3e
to
82af6fa
Compare
|
If this looks ok from an API and rough approach standpoint, I can look into details, tests, compliance with Skaffold project standards, etc. One open edge case question would be how to handle if someone passes Another one would be whether include any special handling for hierarchical skaffold platforms like Let me know, thanks! |
aran
changed the title
|
@renzodavid9 I updated the PR title and top-level comment to meet project guidelines. This is now ready for review.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9300 +/- ##
==========================================
- Coverage 70.48% 63.21% -7.28%
==========================================
Files 515 642 +127
Lines 23150 32989 +9839
==========================================
+ Hits 16317 20853 +4536
- Misses 5776 10527 +4751
- Partials 1057 1609 +552 ☔ View full report in Codecov by Sentry. |
This change introduces an artifact-level setting for configuring Bazel and defines a platform mapping from Skaffold platforms to Bazel platforms. The Bazel artifact builder then passes the --platforms flag to Bazel if applicable. Fixes #9360.
Summary: According to ./hack/check-samples.sh, ''' # /examples should use the latest released version LATEST_RELEASED="skaffold/$(go run ./hack/versions/cmd/latest_released/version.go)" ''' The new 'platforms' field is in v4beta10 and not available in a released version yet, so CI fails. It can be added to /examples/bazel later, after a release. Test Plan: `./hack/check-samples.sh`
* Update Bazel builder documentation to include an example * Update Skaffold cross-platform page to document that Bazel cross-platform builds are now supported. Depends on #9300. Tested with `make preview-docs-v2`. Note unrelated POSTCSS error present in main in `./hack/check-docs.sh`/`make build-docs-preview`
This change introduces an artifact-level setting for configuring Bazel and
defines a platform mapping from Skaffold platforms to Bazel platforms.
The Bazel artifact builder then passes the --platforms flag to Bazel if applicable.
Fixes #9360.