Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Bazel platform mappings #9300

Merged
merged 6 commits into from
Apr 2, 2024
Merged

feat: Support Bazel platform mappings #9300

merged 6 commits into from
Apr 2, 2024

Commits on Mar 29, 2024

  1. feat: Support Bazel platform mappings 

    This change introduces an artifact-level setting for configuring Bazel and
defines a platform mapping from Skaffold platforms to Bazel platforms.
The Bazel artifact builder then passes the --platforms flag to Bazel if applicable.

Fixes #9360.
    @aran
    aran committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    8d48816 View commit details
    Browse the repository at this point in the history

  2. Update examples/bazel

    @aran
    aran committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b4db5fe View commit details
    Browse the repository at this point in the history

  3. Copy examples/bazel to integration/examples/bazel

    @aran
    aran committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    260525d View commit details
    Browse the repository at this point in the history

  4. Add unit test

    @aran
    aran committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    80800cb View commit details
    Browse the repository at this point in the history

  5. Remove bazel platforms from examples/bazel 

    Summary: According to ./hack/check-samples.sh,

'''
# /examples should use the latest released version
LATEST_RELEASED="skaffold/$(go run ./hack/versions/cmd/latest_released/version.go)"
'''

The new 'platforms' field is in v4beta10 and not available in a released version yet, so CI fails.

It can be added to /examples/bazel later, after a release.

Test Plan: `./hack/check-samples.sh`
    @aran
    aran committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    c8eedb2 View commit details
    Browse the repository at this point in the history

  6. Remove yaml block that breaks docs

    @aran
    aran committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    03f8acc View commit details
    Browse the repository at this point in the history