Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 15.0.1 #63170

Closed
wants to merge 2 commits into from
Closed

node 15.0.1 #63170

wants to merge 2 commits into from

Conversation

diogoazevedos
Copy link
Contributor

@diogoazevedos diogoazevedos commented Oct 20, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 20, 2020
@diogoazevedos
Copy link
Contributor Author

==> Downloading https://registry.npmjs.org/npm/-/npm-7.0.0.tgz
######################################################################## 100.0%
==> Downloading https://nodejs.org/dist/v15.0.0/node-v15.0.0.tar.gz
######################################################################## 100.0%
==> ./configure --prefix=/usr/local/Cellar/node/15.0.0 --without-npm --with-intl=system-icu
==> make install
==> node /private/tmp/node-20201020-66889-r6unch/node-v15.0.0/npm_bootstrap/bin/npm-cli.js install -ddd --glob
Last 15 lines from /Users/diogoazevedos/Library/Logs/Homebrew/node/03.node:
npm verb argv "/usr/local/Cellar/node/15.0.0/bin/node" "/private/tmp/node-20201020-66889-r6unch/node-v15.0.0/npm_bootstrap/bin/npm-cli.js" "install" "-ddd" "--global" "--prefix=/usr/local/Cellar/node/15.0.0/libexec" "/Users/diogoazevedos/Library/Caches/Homebrew/downloads/795a7354ab674b9b41e3574251623fea3c9a4aa987a13c81b5224e73f1876f2e--npm-7.0.0.tgz"
npm verb node v15.0.0
npm verb npm  v7.0.0
npm ERR! code ENOENT
npm ERR! syscall lstat
npm ERR! path /usr/local/Cellar/node/15.0.0/libexec
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, lstat '/usr/local/Cellar/node/15.0.0/libexec'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 
npm verb exit -2
npm timing npm Completed in 2767ms

npm ERR! A complete log of this run can be found in:
npm ERR!     /private/tmp/node-20201020-66889-r6unch/node-v15.0.0/.brew_home/.npm/_logs/2020-10-20T16_34_36_133Z-debug.log

@SMillerDev
Copy link
Member

Please don't add a node@14 formula unless it fulfills all requirements in https://docs.brew.sh/Versions

@billinghamj
Copy link
Contributor

billinghamj commented Oct 21, 2020

This might also be a good time to remove the OpenSSL ASM patch:

https://github.com/Homebrew/homebrew-core/pull/63170/files#diff-074ce911bbf848cc1258962b3527853528213ced30b268e5de23309d856b158dR39-R41

    # Remove `--openssl-no-asm` workaround when upstream releases a fix
    # See also: https://github.com/nodejs/node/issues/34043
    args << "--openssl-no-asm" if Hardware::CPU.arm?

I don't think that should be required any more - though needs to be validated

Should have been resolved in: nodejs/node#34238

SMillerDev
SMillerDev previously approved these changes Oct 22, 2020
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @diogoazevedos ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@janosh
Copy link

janosh commented Oct 22, 2020

Thanks @diogoazevedos! Looking forward to this.

@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @SMillerDev bottle publish failed.

@BrewTestBot BrewTestBot dismissed SMillerDev’s stale review October 23, 2020 06:45

bottle publish failed

@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@diogoazevedos diogoazevedos deleted the node-15.0.0 branch October 23, 2020 18:39
@diogoazevedos diogoazevedos mentioned this pull request Oct 26, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants