mermaid-cli 8.8.4 (new formula)

[BastianZim]

mermaid-cli 8.8.4 (new formula)

Add formula

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[BastianZim]

@carlocab This would be the new PR.

Thanks again for your help and sorry for the extra work.

[carlocab]

Thanks again, @BastianZim.

[BastianZim]

@carlocab Seems like chromium is not yet available for ARM: https://github.com/Homebrew/homebrew-core/pull/67804/checks?check_run_id=1614088150#step:7:563

Is there anything I can do or should I just report that to the maintainers?

[carlocab]

Yes, I noticed... https://chromium.googlesource.com/chromium/src.git/+/master/docs/mac_arm64.md

Let's just wait and see if others have feedback on this before we decide what to do next.

[carlocab]

@fxcoudert do you have an opinion on this? It seems like a popular piece of software: https://www.npmjs.com/package/@mermaid-js/mermaid-cli

[BastianZim]

Just to add: The problem comes from the package puppeteer which interacts with Chromium.
Also see: puppeteer/puppeteer#6622

[chrmoritz]

I think the questions is here more if we want to ship the bottle with a downloaded third-party compiled chromium binary here or do we want to just set the PUPPETEER_SKIP_CHROMIUM_DOWNLOAD env var and maybe tell the user in a caveat how to point it to a locally installed Chrom{e,ium] with PUPPETEER_EXECUTABLE_PATH.

[fxcoudert]

@chrmoritz let's try to minimise the number of chromium builds we distribute as part of other things

[carlocab]

Sounds like pupeteer downloads and installs a pre-compiled Chromium binary, though. Does that disqualify this from homebrew-core?

Not to mention that forcing it not to download Chromium means we'd have to provide one during the test.

[chrmoritz]

I think that wouldn't be a problem, since puppeteer will also download it's precompiled chromium binary during runtime, if PUPPETEER_EXECUTABLE_PATH doesn't point to a valid Chrom{e,ium] executable. PUPPETEER_SKIP_CHROMIUM_DOWNLOAD just skips the download during the installation, if I read the code at https://github.com/puppeteer/puppeteer/blob/f63a123ecef86693e6457b07437a96f108f3e3c5/src/node/Launcher.ts#L606 correctly.

However it will never work on arm macs, because it hardcodes /usr/bin/chromium-browser on every arm64 system: https://github.com/puppeteer/puppeteer/blob/f63a123ecef86693e6457b07437a96f108f3e3c5/src/node/Launcher.ts#L107

[BastianZim]

Hi everybody, just wanted to check if there is anything else I can do or if we're just waiting for further feedback concerning ARM?

[chenrui333]

Nope. Good to 🚢 !!

Thanks @BastianZim for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

[BrewTestBot]

@chenrui333 has triggered a merge.