Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf: build python bindings for 3.10 too #87287

Closed
wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Oct 15, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

We're migrating a number of protobuf dependents to Python 3.10 in #87277.

We could migrate protobuf fully to Python 3.10 there too, but I'd like
to avoid pulling in protobuf's dependency tree into the CI run there.

@carlocab carlocab added CI-long-timeout Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. python-3.10-migration labels Oct 15, 2021
@carlocab
Copy link
Member Author

Linux failures are from swift and libffi.

@cclauss
Copy link
Contributor

cclauss commented Oct 15, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Nov 6, 2021
@cclauss
Copy link
Contributor

cclauss commented Nov 6, 2021

Python 3.10 compatibility was landed upstream in release 3.19.0.
https://github.com/protocolbuffers/protobuf/releases

@github-actions github-actions bot removed the stale No recent activity label Nov 6, 2021
This was referenced Nov 25, 2021
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Nov 28, 2021
@carlocab carlocab added CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. and removed stale No recent activity CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-skip-dependents Pass --skip-dependents to brew test-bot. labels Nov 28, 2021
We're migrating a number of protobuf dependents on Python 3.10 in Homebrew#87277.

We could migrate protobuf fully to Python 3.10 there too, but I'd like
to avoid pulling in protobuf's dependency tree into the CI run there.
@cclauss
Copy link
Contributor

cclauss commented Dec 1, 2021

Nice!

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab carlocab deleted the py310-protobuf branch December 1, 2021 17:50
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-long-timeout Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age python-3.10-migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants