Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencv 4.5.4 #89948

Closed
wants to merge 9 commits into from
Closed

opencv 4.5.4 #89948

wants to merge 9 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 25, 2021 •
edited

Created with brew bump-formula-pr.

resource blocks may require updates.

Recapitulates #87064

Removed openalpr because it has not been updated since 2016 and fails tests on a well-documented AssertionError:

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` python Python use is a significant feature of the PR or issue labels Nov 25, 2021
carlocab
carlocab reviewed Nov 25, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  libc++abi: terminating with uncaught exception of type std::bad_alloc: std::bad_alloc

Deleting openalpr to deal with the system not being able to allocate memory seems like the wrong thing to do here.

cclauss added a commit to cclauss/openalpr that referenced this pull request Nov 25, 2021
@cclauss
class Alpr: Set self.loaded to False before exception
b352e75 
There are currently [46 open issues related to `loaded`](https://github.com/openalpr/openalpr/search?p=2&q=loaded&type=issues).  Many of these [`AttributeError` issues](https://github.com/openalpr/openalpr/search?q=AttributeError&type=issues) are caused because `self.loaded` is only defined at the end of this method on (line 117).  If an exception is raised (like line 62, etc.) then `self.loaded` is _never_ defined so subsequent code fails when trying to determine if `Alpr` has successfully loaded.

Closes openalpr#311
Closes openalpr#414
Closes openalpr#426
Closes openalpr#461 
Closes openalpr#508
Closes openalpr#533
Closes openalpr#660
Closes openalpr#732
Closes openalpr#738
Closes openalpr#764
Closes openalpr#806
Closes openalpr#837 
Closes openalpr#913 
Closes openalpr#916 
Related to openalpr#555
Related to Homebrew/homebrew-core#89948
@cclauss cclauss mentioned this pull request Nov 25, 2021
Closed
@cclauss
Copy link
Contributor Author

cclauss commented Nov 25, 2021

Please add the python-3.10-migration label to this PR because this openalpr problem blocks:

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Nov 27, 2021
@cclauss
Copy link
Contributor Author

cclauss commented Nov 27, 2021 •
edited

@matthill @bayandin Do you have any insight into these failures we get when trying to test against:
https://upload.wikimedia.org/wikipedia/commons/b/b0/California_2018_license_plate_%28USA%29.jpg

==> brew test --retry --verbose openalpr
==> FAILED
Full test openalpr output
  ==> Testing openalpr
  cp -p /Users/brew/Library/Caches/Homebrew/downloads/195774c820111f890a628e11f0544ab624568a4435ed3e29408b0a5e3c18a70d--California_2018_license_plate_(USA).jpg /private/tmp/openalpr--testdata-20211125-79036-1lrsu4r/California_2018_license_plate_(USA).jpg
  ==> /opt/homebrew/Cellar/openalpr/2.3.0_2/bin/alpr plate.jpg
  libc++abi: terminating with uncaught exception of type std::bad_alloc: std::bad_alloc
  
  Error: openalpr: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 0
    Actual: nil

@github-actions github-actions bot removed the stale No recent activity label Nov 27, 2021
@bayandin
Copy link
Member

bayandin commented Nov 27, 2021 •
edited

@matthill @bayandin Do you have any insight into these failures we get when trying to test against: https://upload.wikimedia.org/wikipedia/commons/b/b0/California_2018_license_plate_%28USA%29.jpg

==> brew test --retry --verbose openalpr
==> FAILED
Full test openalpr output
  ==> Testing openalpr
  cp -p /Users/brew/Library/Caches/Homebrew/downloads/195774c820111f890a628e11f0544ab624568a4435ed3e29408b0a5e3c18a70d--California_2018_license_plate_(USA).jpg /private/tmp/openalpr--testdata-20211125-79036-1lrsu4r/California_2018_license_plate_(USA).jpg
  ==> /opt/homebrew/Cellar/openalpr/2.3.0_2/bin/alpr plate.jpg
  libc++abi: terminating with uncaught exception of type std::bad_alloc: std::bad_alloc
  
  Error: openalpr: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 0
    Actual: nil

If I understand it correctly, openalpr can't allocate enough memory for processing that image. You could try to use a smaller one: https://upload.wikimedia.org/wikipedia/commons/thumb/b/b0/California_2018_license_plate_%28USA%29.jpg/320px-California_2018_license_plate_%28USA%29.jpg

carlocab
carlocab requested changes Nov 27, 2021
View reviewed changes
Formula/openalpr.rb Outdated
Comment on lines 10 to 12
sha256 arm64_big_sur: "4413a608d96584a63180fcb7a8d1c794ef8277010b9bd76f03c3bdfd60e3fe5a"
sha256 big_sur: "a686b58100f9c397a2be1eb70595c773440e26e652a8539745bcfebd38359b12"
sha256 catalina: "c1ba59a1d018a65f019ea162dd44efefc28ef54720f5b702c3763f21b5bdbb65"
sha256 mojave: "6b61f23a1832eaea3acebf2ac5333d96eaa2ac9f978b8c1dbe6cfabadf0e980c"
sha256 x86_64_linux: "a37d2f029a47097ea7c81936ed0400451780ae75594cf4aae10cc1647e5bc93e"
sha256 big_sur: "32953a90e352cc25eea99daad7fac67c7ce11f042fe366af029b16cc3f372c07"
sha256 catalina: "0a05746932c63e1d0dd1749a7213ed0a9cff7d7da2cdfe49e032aeb1b1da56ad"
sha256 mojave: "64dd8cef3f2fe311304e0fffae5ed50dd37123d6611aae751ba272be956bf334"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't touch the bottle block.

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 27, 2021
@cclauss cclauss closed this Nov 28, 2021
@cclauss cclauss deleted the bump-opencv-4.5.4 branch November 28, 2021 19:12
@cclauss cclauss mentioned this pull request Dec 3, 2021
Closed
@bayandin bayandin mentioned this pull request Dec 3, 2021
Merged
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab requested changes

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-3.10-migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cclauss @bayandin @carlocab @SMillerDev @BrewTestBot