Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openalpr: deprecate #90371

Merged
merged 1 commit into from
Dec 5, 2021
Merged

openalpr: deprecate #90371

merged 1 commit into from
Dec 5, 2021

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Dec 3, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The latest release of openalpr was in 2016, the formula already patched (with upstream changes) to support the latest versions of dependencies.
It started to give us some troubles in tesseract (#90220) and opencv (#89948) updates.

==> Analytics
install: 91 (30 days), 281 (90 days), 906 (365 days)
install-on-request: 91 (30 days), 281 (90 days), 905 (365 days)
build-error: 10 (30 days)

@BrewTestBot BrewTestBot added formula disabled Formula disabled python Python use is a significant feature of the PR or issue labels Dec 3, 2021
@carlocab
Copy link
Member

carlocab commented Dec 3, 2021

Can we switch it back to opencv@3 and deprecate it? We should at least try to have a deprecation period.

@bayandin
Copy link
Member Author

bayandin commented Dec 3, 2021

Can we switch it back to opencv@3 and deprecate it?

Why? It'll stop working with the next version of tesseract anyway.

@SMillerDev
Copy link
Member

Why? It'll stop working with the next version of tesseract anyway.

Because that will give people a window to notice the deprecation

@alalek alalek mentioned this pull request Dec 4, 2021
@bayandin
Copy link
Member Author

bayandin commented Dec 4, 2021

Why? It'll stop working with the next version of tesseract anyway.

Because that will give people a window to notice the deprecation

Ah sorry, my question was rather about Can we switch it back to opencv@3 part.

Changed disable to deprecate.

@bayandin bayandin changed the title openalpr: disable openalpr: deprecate Dec 4, 2021
@BrewTestBot BrewTestBot added formula deprecated Formula deprecated and removed formula disabled Formula disabled labels Dec 4, 2021
@iMichka iMichka merged commit b3716bf into Homebrew:master Dec 5, 2021
@bayandin bayandin deleted the openalpr-disable branch December 6, 2021 11:17
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
formula deprecated Formula deprecated outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants