Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: importOrderCombineTypeAndValueImports #20

Merged
merged 26 commits into from Oct 24, 2022
Merged

Feature: importOrderCombineTypeAndValueImports #20

merged 26 commits into from Oct 24, 2022

Commits on May 18, 2022

  1. Add TypeScript enforcement to not-forgetting our Options schema!

    @fbartho
    fbartho committed May 18, 2022
    Copy the full SHA
    d4df2f0 View commit details
    Browse the repository at this point in the history

  2. Change syntax of getCodeFromAst to allow for node deletion

    @fbartho
    fbartho committed May 18, 2022
    Copy the full SHA
    cf4e6af View commit details
    Browse the repository at this point in the history

  3. Github-linguist doesn't understand ecmascript 6 

    Just use javascript or js
    @fbartho
    fbartho committed May 18, 2022
    Copy the full SHA
    f03f96b View commit details
    Browse the repository at this point in the history

  4. Feature: importOrderMergeDuplicateImports - Fixes #4

    @fbartho
    fbartho committed May 18, 2022
    Copy the full SHA
    6c47166 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fb/simplify-import-duplicates

    @fbartho
    fbartho committed May 18, 2022
    Copy the full SHA
    dc43318 View commit details
    Browse the repository at this point in the history

  6. Feature: importOrderMergeTypeImportsIntoRegular 

    Fixes: #4

Allows the ability for users to convert `import type` expressions into `import {type …}` expressions via a boolean flag.

Should this be controlled via a string parameter?
    @fbartho
    fbartho committed May 18, 2022
    Copy the full SHA
    a62bcd1 View commit details
    Browse the repository at this point in the history

  7. merge-tests: extract defaultOptions

    @fbartho
    fbartho committed May 18, 2022
    Copy the full SHA
    db923e7 View commit details
    Browse the repository at this point in the history

  8. merge-imports: Add test cases from codemod 

    https://github.com/IanVS/type-import-codemod/blob/9f3210861a77216f07317537a04ce61467e0df7e/src/transform.test.ts
    @fbartho
    fbartho committed May 18, 2022
    Copy the full SHA
    e2ab51d View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. switch from toMatchInlineSnapshot to toEqual

    @fbartho
    fbartho committed May 19, 2022
    Copy the full SHA
    9ef2abe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fb/simplify-import-duplicates' into fb/merge-type-impor… 

    …ts-with-regular-imports
    @fbartho
    fbartho committed May 19, 2022
    Copy the full SHA
    61f7797 View commit details
    Browse the repository at this point in the history

  3. switch from toMatchInlineSnapshot to toEqual

    @fbartho
    fbartho committed May 19, 2022
    Copy the full SHA
    8edeb51 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. PR Feedback: rename regular imports to value imports

    @fbartho
    fbartho committed May 20, 2022
    Copy the full SHA
    f5f9e26 View commit details
    Browse the repository at this point in the history

  2. PR Feedback: Readme wording

    @fbartho
    fbartho committed May 20, 2022
    Copy the full SHA
    42999c9 View commit details
    Browse the repository at this point in the history

  3. PR Feedback: rename getCodeFromAst parameters 

    Try to improve the naming and docs for the parameters, particularly the nodes vs importNodes distinciton
    @fbartho
    fbartho committed May 20, 2022
    Copy the full SHA
    2fe3128 View commit details
    Browse the repository at this point in the history

  4. PR Feedback: import-flavor @returns documentation

    @fbartho
    fbartho committed May 20, 2022
    Copy the full SHA
    e393e5e View commit details
    Browse the repository at this point in the history

  5. PR Feedback: hoist hasIgnoreNextNode for reuse

    @fbartho
    fbartho committed May 20, 2022
    Copy the full SHA
    e569488 View commit details
    Browse the repository at this point in the history

  6. PR Feedback: Add strong types for ChunkType/FlavorType

    @fbartho
    fbartho committed May 20, 2022
    Copy the full SHA
    0e3a871 View commit details
    Browse the repository at this point in the history

  7. PR Feedback: deleteContext -> nodesToDelete

    @fbartho
    fbartho committed May 20, 2022
    Copy the full SHA
    d0a2692 View commit details
    Browse the repository at this point in the history

  8. PR Feedback: comment-update: once you mutate nodes, lines/locations a… 

    …re stale!
    @fbartho
    fbartho committed May 20, 2022
    Copy the full SHA
    6cb7764 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'fb/simplify-import-duplicates' into fb/merge-type-impor… 

    …ts-with-regular-imports
    @fbartho
    fbartho committed May 20, 2022
    Copy the full SHA
    3c3c142 View commit details
    Browse the repository at this point in the history

  10. PR Feedback: apply getCodeFromAst renames

    @fbartho
    fbartho committed May 20, 2022
    Copy the full SHA
    99b6716 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Merge branch 'main' into fb/merge-type-imports-with-regular-imports 

    # Conflicts:
#	README.md
#	src/index.ts
#	src/preprocessor.ts
#	src/types.ts
#	src/utils/__tests__/get-all-comments-from-nodes.spec.ts
#	src/utils/__tests__/get-code-from-ast.spec.ts
#	src/utils/__tests__/get-sorted-nodes-by-import-order.spec.ts
#	src/utils/__tests__/get-sorted-nodes.spec.ts
#	src/utils/__tests__/merge-nodes-with-matching-flavors.spec.ts
#	src/utils/__tests__/remove-nodes-from-original-code.spec.ts
#	src/utils/get-sorted-nodes.ts
#	src/utils/merge-nodes-with-matching-flavors.ts
    @fbartho
    fbartho committed Jun 15, 2022
    Copy the full SHA
    826a973 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Minor review comments

    @IanVS
    IanVS committed Oct 24, 2022
    Copy the full SHA
    03b9926 View commit details
    Browse the repository at this point in the history

  2. Group type imports after value in importOrderSortSpecifiers

    @IanVS
    IanVS committed Oct 24, 2022
    Copy the full SHA
    beb9066 View commit details
    Browse the repository at this point in the history

  3. Rename option for clarity

    @IanVS
    IanVS committed Oct 24, 2022
    Copy the full SHA
    75b11fe View commit details
    Browse the repository at this point in the history

  4. Add TOC to readme, re-arrange a bit

    @IanVS
    IanVS committed Oct 24, 2022
    Copy the full SHA
    a5e4f6b View commit details
    Browse the repository at this point in the history